search

Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

XReceive fails to record msg if no gas #638

Open 0xdcota opened 1 year ago

0xdcota commented 1 year ago

This pull request addresses Item #-21 of the Three Sigma security audit.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fuji-v2-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/fuji-finance/fuji-v2-frontend/FnkksmYHiNNZYLDoeQVYkAVJh1J1)) | | | Jun 28, 2023 8:31pm |
0xdcota commented 1 year ago

@0x73696d616f this pull request is still in draft, but please check the comment in attached issue.

0xdcota commented 1 year ago

@0x73696d616f I believe I finally understood, please review. Also I found that the catch-block when recording a failed txn can vary with our current ConnextHandler-recordFailed(..) implementation.