Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Simplified navigation bar #680

Closed ferostabio closed 9 months ago

ferostabio commented 10 months ago

close #670 close #671 close #683

Captura de pantalla 2023-07-31 a la(s) 15 58 29
vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuji-v2-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 1:49pm
ferostabio commented 10 months ago

@brozorec have a look! we're showing positions at risk based on ltvMax - ltv, what would be the right amount to consider a position at risk? or would you like a different approach?

brozorec commented 10 months ago

Good job :muscle: I like it, like also the idea to have it as a loader.

@brozorec have a look! we're showing positions at risk based on ltvMax - ltv, what would be the right amount to consider a position at risk? or would you like a different approach?

I'd say we consider a position at risk when ltvMax - ltv < 10%


2 suggestions:

  1. when the notification circle is green and the user clicks on it, we open the notification popover with a message instead of a tooltip as it's proposed in the design. This will give us some space to put a CTA "Create notification" in the future when we are going to implement this feature.
  2. When the user hovers over the network icon, we unfold the name with the dropdown instead of displaying a tooltip.

wdyt @Markoyw ?

Markoyw commented 10 months ago

Yeah, that makes sense. We used to have a mock-up design for that, integrating with Hal notification

Screenshot 2023-07-20 at 11 12 02 PM
NikolaiYurchenko commented 10 months ago

In case of success state add menu content to show 1st case ( no positions ) 2nd case ( position are healthy )

ferostabio commented 9 months ago

@NikolaiYurchenko the first time we load the new account modal, there's a slight delay before we show assets. To be expected, of course. Lets add the same type of skeleton we show for markets, since having an empty list looks a bit weird. Show enough elements so they cover all the screen, since even before adding more chains we already have more than 10 tokens.