search

Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Router replace amout after soft max withdrawal #681

Closed 0xdcota closed 9 months ago

0xdcota commented 9 months ago

This pull request addresses the router issue of replacing arguments when the encoded amounnt-arg in actions after a Withraw happens differs from the "real" amount received.

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fuji-v2-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/fuji-finance/fuji-v2-frontend/69PFAV6Yzj8pbCBMKPPsy4ZDQvps)) | | | Jul 26, 2023 9:15am |
0xdcota commented 9 months ago

Hey @brozorec ready for review: Issue related to:

The other issue is in the router. After doing the a soft-withdrawal, I want to cross-transfer but as I withdrew less than what was encoded in the cross-transfer action

The PR actually addresses all the Action cases after a soft-max withdraw.

0xdcota commented 9 months ago

I checked the refactors, they all look good on my side.