Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Research Bulker in Compound #689

Closed pedrovalido closed 8 months ago

0xdcota commented 9 months ago

I provided feedback on why the Compound Bulker.sol contract is safe to use without additional signatures or checks. The Bulker.sol checks that the caller is the msg.sender of the set of actions that will be performed. That way there is no risk of a third party taking advantage of the "operator" role that the Bulker has.

In our particular case, we have to implement a form of signature because our HimalyaCompound.sol is not called by the owner of the actions to be performed.

That is why we need carry some type of permit, as we do similarly in our BaseRouter.sol process. @pedrovalido

Just note this and close issue.