UI issues

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
fuji-v2-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 21, 2023 11:38am

[ferostabio]

@NikolaiYurchenko I was playing around with the work you did, and I think everything we're doing is actually worst. Now... I realized that the underlying issue is that we have one MarketsTable with two different data sources. Let's just have two tables and show one of them according to the selected tab! No transition will be needed (tableData will have to be an array containing both sets of data)

[ferostabio]

Since you're at it, please have a look at this two things:

• [x] "..." is not centered.

  

• [x] For lending positions, we should show "+" instead of "-"

  

[ferostabio]

Thanks for the fixes @NikolaiYurchenko 😁

The glitch is still there, though. Wasn't expecting that, since they are now different tables. I would say...

1 - Try to see if there is a way out of it. They are different tables after all now. 2 - If you find no way out, do implement the loader... but not just one row. We have the row count for each list, so we can now how many skeleton rows to show (and for a bit less time)

[ferostabio]

Another small UI issue @NikolaiYurchenko ! Left panel shouldn't change width when the "...after..." component appears.

https://github.com/Fujicracy/fuji-v2/assets/501915/878295e0-25c8-48c2-861d-49a144af1cec

[NikolaiYurchenko]

Thanks for the fixes @NikolaiYurchenko 😁

The glitch is still there, though. Wasn't expecting that, since they are now different tables. I would say...

1 - Try to see if there is a way out of it. They are different tables after all now. 2 - If you find no way out, do implement the loader... but not just one row. We have the row count for each list, so we can now how many skeleton rows to show (and for a bit less time)

well, it will be blinking just because it is insta-changing, moreover on a dark background

[ferostabio]

well, it will be blinking just because it is insta-changing, moreover on a dark background

If you play the video in slow motion the issue is super clear 😅 (do vlc at .25x). For a brief moment, while switching tabs, you get lending data on the borrowing table and borrowing data on the lending one.

Have a look at the attached screenshot. Have I switched from borrowing to lending, and while its going to show the right info, you can see here that its showing borrowing data. Since we move this data around, its really visible and it produces the glitch.

1 - Switched to lending, showing borrowing data

2 - Finally shows lending data

3 - Same thing happens going back to borrowing

[ferostabio]

We are fixing a couple of minor UI issues here, but want your feedback about something @Markoyw !

If you visit the production app, when you switch from borrowing to lending in the markets page, the experience is not great. Same thing happens in the positions page, to a lesser degree -there is a data missmatch, for a brief moment, and it feels a bit weird. We tried a couple solutions, and the best thing we came up with is showing a loader to smooth the transition.

Please visit this link to have a look.

Agree? Disagree? Ideas?

[Markoyw]

Agree, I like it a lot!