search

FujoWebDev / AO3.js

NodeJS API for scraping AO3 data
MIT License
15 stars 8 forks source link

Add the series index page #52

Closed hkamran80 closed 10 months ago

hkamran80 commented 10 months ago

Part of #36

hkamran80 commented 10 months ago

You're welcome!! I'm happy to help!!

essential-randomness commented 10 months ago

Just FYI, I made a further change by mocking the requests to AO3 rather than using the live pages (see: https://github.com/Fandom-Coders/AO3.js/pull/54, and the library we use for this: https://mswjs.io/).

No problem at all with your PR, one day we'll actually run the tests before submission and also document how to do this :) this was a good chance to have a sample PR for this.

Once again, thank you so much for contributing.

hkamran80 commented 10 months ago

Knew I forgot to do something! I saw the mocks, but I forgot to download the page and register it before I made PR ready. Thank you for catching that!