Adding test cases and test coverage

[cmoiceanu]

Adding tests cases for different areas • Create House • Add House Members • User Login/Logout • Password Change, • Password Recovery • Create Announcement • Create Task * • Etc…

*Indicates there are a few snags than need to be sorted out to make the test do what it needs to do. I wanted the check these in anyway as the majority of the test setup is already in place and making it work will require a lot less work.

This check-in requires that you rerun pip –r install requirements to pick up the coverage toolset.

To run the entire test with coverage: In the root of ‘fullhouse’ execute all_tests.sh script, when this script completes it generates the test coverage numbers.

As you add new functionality, it might be useful to run this entire suite of tests to see if the exiting functionality still works. If you add functionality that breaks an existing test case, you might consider updating the test case to reflect the changes. The plan here is to continue adding more test cases and to improve the coverage. I think right now we are slightly above 60% coverage, but that doesn’t mean squat, need to have more tests for many more cases.

[j3ffml]

Looks good, just a couple recommendations:

• It looks like every testcase has the same setup and createUser functions. Rather than duplicating all that code between them, you can make a base class (call it, e.g. FullHouseTestCase), put the common setup code in that one, and have all your other tests extend that class. Alternatively, if you can figure out how to put the user data in test fixtures, you can use the same one for each case.
• Tasks are getting reworked, so I would say don't bother with that testcase until after the new changes are merged.
• test_login_logout is basically duplicating tests in auth/tests/test_auth; probably just need one set of tests for that functionality.

[cmoiceanu]

Initially I held back on the refactoring to using base test class because I was not entirely convinced I’ll have it working right (my lack of understanding python and Django in general). I have applied tests case refactoring and they all work fine. I will submit cleaner package shortly.

Fundamentally yes, we both test that user login, but we are taking different approaches. In my case for login/logout I actually check that user is in (or not in) the current session. I wanted to preserve this technique somehow (took me a while to figure it out). More tests will not hurt, and I did not want to remove your test from its location. As you have also noticed, I centralized tests to a single location, I do not want to impose this on anybody else but I prefer that test code is clustered together (which also makes refactoring of reusable test case code more intuitive).

[cmoiceanu]

Refactored test cases are in

[j3ffml]

Looks alright. merging.