search

Full-House-UW / fullhouse

Full House: a household management tool
fullhousemanager.com
0 stars 6 forks source link

Added a confirmation when switching houses. #272

Closed creisman closed 11 years ago

creisman commented 11 years ago

Displays a bootbox dialog when the user tries to join a house when they're already in another house. It only appears if the invitation is accepted.

j3ffml commented 11 years ago

Pulled down and tested; works as advertised. If you rerun tests and fix the pep8 errors (inconsistent indentation), I will merge.

creisman commented 11 years ago

Damn it, I realized I hadn't done that a few minutes ago and was hoping I'd get the fix in before anyone noticed it. It's in.

On Sat, Dec 8, 2012 at 1:54 PM, Jeff Lowdermilk notifications@github.comwrote:

Pulled down and tested; works as advertised. If you rerun tests and fix the pep8 errors (inconsistent indentation), I will merge.

— Reply to this email directly or view it on GitHubhttps://github.com/Full-House-UW/fullhouse/pull/272#issuecomment-11164194.

j3ffml commented 11 years ago

LGTM and tests pass.