search

Full-House-UW / fullhouse

Full House: a household management tool
fullhousemanager.com
0 stars 6 forks source link

Create_house page still exists. #281

Open creisman opened 11 years ago

creisman commented 11 years ago

It doesn't work, but the page is still there. The template and URL should both be erased. Nothing links to it, so I'm just putting this here for documentation.

j3ffml commented 11 years ago

Don't we only have one create_house page? or do you mean it should be deactivated if you already have a house?

creisman commented 11 years ago

create_house was inserted into nonhousemember.html, which is the template displayed for /dashboard/ when you're not part of a house. You can also go to /dashboard/create_house/ at any time and it displays nonhousemember.html with no form, which means the entry in urls.py is still there.

A better implementation, had I been smart enough when I did this, would have been to redirect from /dashboard/ to another page when the user is not part of a house. Then we would have reused create_house and not doubled up on dashboard. If this ever gets fixed, that's how I would actually implement it.

On Sun, Dec 9, 2012 at 12:40 AM, Jeff Lowdermilk notifications@github.comwrote:

Don't we only have one create_house page? which one is this?

— Reply to this email directly or view it on GitHubhttps://github.com/Full-House-UW/fullhouse/issues/281#issuecomment-11169008.