search

FullControlXYZ / fullcontrol

Python version of FullControl for toolpath design (and more) - the readme below is best source of information
GNU General Public License v3.0
672 stars 78 forks source link

Fix Pydantic Versioning issue #33

Closed Keelan-Moore closed 1 year ago

Keelan-Moore commented 1 year ago

Fix based on Issue 31 raised by basti00.

Fix Description: I ran Pydantics version migration tool, pydantic-bump which fixed some issues but missed all classes containing Optional[T] where the default wasn't set. Following the rule set in there migration tool I changed Optional fields to include a default of None where one wasn't set (note the first rule in their Readme).

I used the regex expression Optional\[[^\]]*\](?!\s*=) to find all instances but I may have missed some, or missed some other issues (this is my first PR for this project) with migration.

I did test to see if the Jupyter notebooks run locally, which they do but I haven't done any more comprehensive testing than running all notebooks

AndyGlx commented 1 year ago

That's great thanks. I'll do some tests and then merge!