gitignore database.db, and remove it from source code

andylolz commented 5 months ago

database.db is in version control, presumably added in error. It should be removed and gitignored.

dcorney commented 5 months ago

Not sure about this one: it might be useful to have a sample of extracted claims/processed videos here rather than starting from scratch. Plus we can store training data in here. Ideally, we'd have scripts to export/import/merge different samples but that's not needed for the MVP.

andylolz commented 5 months ago

Not sure about this one: it might be useful to have a sample of extracted claims/processed videos here rather than starting from scratch. Plus we can store training data in here. Ideally, we'd have scripts to export/import/merge different samples but that's not needed for the MVP.

^^ @dcorney the problem with doing that is: as soon as anyone writes to the database, they end up with local changes (that can then end up accidentally being committed to git).

The way to do the thing you’re suggesting is either:

gitignore *.db, and then have a database.db.example in version control that contains some sample data, and that gets moved into place. I.e. the database equivalent of .env.example. Or…
Add a seed script (probably in /tools/db) that auto-populates the database with some sample data

I think either of those is fine.

dcorney commented 5 months ago

I like the seed script idea. I'll create a new issue for it so this can stay closed.

FullFact / health-misinfo-shared

gitignore database.db, and remove it from source code #44