FullFact / health-misinfo-shared

Raphael health misinformation project, shared by Full Fact and Google
MIT License
0 stars 0 forks source link

feature: use absolute imports with package modules #48

Closed ff-dh closed 5 months ago

ff-dh commented 5 months ago

Closes #33 by turning the Python directories into modules and switches to use absolute imports.


Pull request checklist

andylolz commented 5 months ago

Nice. This is definitely preferable to symlinking!

Can src/raphael_backend_flask/prompts.py be removed as part of this PR? I guess it’s no longer used.

Also: vertex.py still exists in two places, i.e. we don’t have a canonical version of that file here.

ff-dh commented 5 months ago

@andylolz I mean to resolve vertex.py in another PR. This was to get a foot in the door with that.

andylolz commented 5 months ago

I mean to resolve vertex.py in another PR. This was to get a foot in the door with that.

^^ That’s fine – sounds good, and +1 for merging.

I’ve reopened #33, just because while this definitely fixes it partially, I think we should keep it open until we just have one copy of these files.