refactor: rationalise into a single version

FullFact / health-misinfo-shared

Raphael health misinformation project, shared by Full Fact and Google

MIT License

0 stars 0 forks source link

refactor: rationalise into a single version #63

Closed andylolz closed 2 months ago

andylolz commented 2 months ago

Refs #33.

This doesn’t completely resolve #33, because there’s still duplicative code in src/raphael_backend_flask/youtube.py and src/health_misinfo_shared/youtube_api.py. But it gets some of the way.

Pull request checklist

[x] I have linked my PR to an issue
[x] I’ve used conventional commits
[x] My branch is up-to-date with main
[ ] Where appropriate, I have added or updated tests
[ ] Where appropriate, I have updated documentation to reflect my changes

andylolz commented 2 months ago

nice one clarifying some variable names

I didn’t do that – that was you! I attempted to merge chunked_transcript and form_chunks. The variable renaming was in chunked_transcript.

andylolz commented 2 months ago

(but I agree – the variable renaming here is good!)