search

FullStackEmbedded / WeatherServer

Django project for serving observations
GNU General Public License v2.0
2 stars 5 forks source link

configure and setup.py, with zypper support #8

Closed wdherndon closed 9 years ago

erget commented 9 years ago

Nice pull request - one thing for the future, if you had worked on a topic branch I could have cloned the branch and then pushed my commit on top of it to keep on working on the PR. As it is, I have to close it and send my own to you for review in order to integrate my commit, which is a bit of a pain. It's not a big deal, and it's not a limitation of git itself, but rather GitHub. Anyway, just a word for the wise - topic branches are the bomb :)

wdherndon commented 9 years ago

I'm not following: a pull request is just that, a request, not a command, right? So, why should it prevent you from doing anything?

-----Original Message----- From: Daniel Lee notifications@github.com To: FullStackEmbedded/WeatherServer WeatherServer@noreply.github.com Cc: William David Herndon wdherndon@aol.com Sent: Mon, Sep 7, 2015 8:33 pm Subject: Re: [WeatherServer] configure and setup.py, with zypper support (#8)

Nice pull request - one thing for the future, if you had worked on a topic branch I could have cloned the branch and then pushed my commit on top of it to keep on working on the PR. As it is, I have to close it and send my own to you for review in order to integrate my commit, which is a bit of a pain. It's not a big deal, and it's not a limitation of git itself, but rather GitHub. Anyway, just a word for the wise - topic branches are the bomb :)

— Reply to this email directly or view it on GitHub.

erget commented 9 years ago

No no, the pull request isn't preventing me from doing anything. Normally though when you have a pull request and people are collaborating on it additional commits to that topic branch are tracked by the pull request. I'm not following: a pull request is just that, a request, not a command, right? So, why should it prevent you from doing anything?

-----Original Message----- From: Daniel Lee notifications@github.com To: FullStackEmbedded/WeatherServer WeatherServer@noreply.github.com Cc: William David Herndon wdherndon@aol.com Sent: Mon, Sep 7, 2015 8:33 pm Subject: Re: [WeatherServer] configure and setup.py, with zypper support (#8)

Nice pull request - one thing for the future, if you had worked on a topic branch I could have cloned the branch and then pushed my commit on top of it to keep on working on the PR. As it is, I have to close it and send my own to you for review in order to integrate my commit, which is a bit of a pain. It's not a big deal, and it's not a limitation of git itself, but rather GitHub. Anyway, just a word for the wise - topic branches are the bomb :)

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/FullStackEmbedded/WeatherServer/pull/8#issuecomment-138355532 .