search

Fumi24 / RunesReformed

38 stars 10 forks source link

Mitigate missing API feed data #13

Closed Codecasaurus closed 3 years ago

Codecasaurus commented 5 years ago

Some champion's sub-pages are missing at the moment I write this because champion.gg does not have data for them. This could be mitigated a few ways but adding alternative supplying APIs could be a solution and likely the easiest to implement. missing notmissing image

Fumi24 commented 5 years ago

This is completly true, but as of right now i dont know of any other external site with an API like champion.gg, i could scrape pages like u.gg for their information but it wouldnt be sustainable like champion.gg is. If you guys know of any site with a public API i would be more than happy to implement it.

etheaven commented 5 years ago

This is completly true, but as of right now i dont know of any other external site with an API like champion.gg, i could scrape pages like u.gg for their information but it wouldnt be sustainable like champion.gg is. If you guys know of any site with a public API i would be more than happy to implement it.

Mind releasing the API which gathers the runes and champions?

Fumi24 commented 5 years ago

@etheaven I just simply gather the data from champion.gg's api, nothing fancy.

danalec commented 5 years ago

Yuumi is missing