search

FunKey-Project / FunKey-OS

Buildroot-based embedded Linux OS for the FunKey S retro-gaming console
https://www.funkey-project.com/
GNU General Public License v2.0
242 stars 65 forks source link

[Regression][Factory Tests] Sound sample is inaudible during the sound test #24

Closed DrUm78 closed 3 years ago

DrUm78 commented 3 years ago

Sound cannot be heard in Factory Tests (Fn+START when booting the console). I first thought it was because there were still some occurrences of "start_audio_amp 0" and "start_audio_amp 1" in "/usr/local/sbin/volume_set" and "/usr/local/sbin/volume_set_alsa". But replacing them with "audio_amp on" and "audio_amp off" did not solve the issue (but I wanted to make sure you knew that some left). This bug does not occur with OS 2.2.0 but only with a custom one built from ffa35c0 ("develop" branch).

Steps to reproduce the behavior:

  1. Build an OS from ffa35c0 commit ("develop" branch)
  2. Boot the console while pressing Fn+START
  3. Launch the Factory Tests
  4. Notice that you cannot hear any sound during the sound test (even at high volume)

Expected behavior Sound should be audible during the Factory sound test.

Michel-FK commented 3 years ago

Fixed in commit 547c1fe, the root cause was the same as issue #22 which only solved the problem for instant replay. I reverted the corresponding commit as this fix works for both cases.

DrUm78 commented 3 years ago

Fixed and verified, thanks!