Open erelson opened 4 years ago
Thank you for your heads up, will improve that part in the following days! Sorry for late response. @erelson
I am really sorry @erelson have been really busy with university, I am now going through an update for this lib. I am now going with the following:
Adding kwargs as you suggested.
For the txbuf
parameter, I added this since I was having problems before with some Dynamixels libraries I coded, and found that assigning 0 to txbuf
basically makes a flush to the serial, which makes the communication better I believe, gotta say I am not really sure, just got used it working like that (will figure out a way to change it)
Regarding the platform condition, I don't have a pyboard, so can't really test for it, however if you can, I would be happy to accept a PR from you.
Also yeah, I am using coded all this using a esp32 with micropython v1.12. Have a good one and thanks again. :smiley:
I've been trying out this library a bit the past two weekends. Really excited that someone else was able to fill this need! And the documentation is pretty great, too.
It seems to me, based on a couple failures so far, that the top-level README should probably note which board(s) is used and what firmware build?
In my case, I'm using a pyboard v1.1; I suspect you folks are working with the ~pyboard D-series (e.g. has wifi).~ esp32 boards
sys.platform == 'pyboard'
uros.NodeHandle(4, 115200)
for example, regarding extra kwargs being given. This, I tracked down to uros' core.py, and apparently the firmware I grabbed is one of those that does not support thetxbuf
kwarg.Now to continue! Will try modifying core.py on my end :+1: