Funbit / ets2-telemetry-server

ETS2/ATS Telemetry Web Server + Mobile Dashboard
GNU General Public License v3.0
624 stars 206 forks source link

Allows disabling the auto-scaling feature #66

Closed denilsonsa closed 8 years ago

denilsonsa commented 8 years ago

Some skins (such as ets2-mobile-route-advisor) might want to have total control of the viewport. For such cases, it is desirable to disable the auto-viewport-scaling and auto-reload-when-size-changes.

This commit implements such behavior by having a non-positive width or height.

I have not changed the files from "source/Funbit*Server/Html", so those must be also changed after this pull request.

I have not updated the documentation, which is also another step after this pull request.

mike-koch commented 8 years ago

Paging @Funbit here. I'm sure you're busy with other stuff, however some feedback would be nice. Myself and @denilsonsa are wrapping up the next release of our skin; however the release is currently blocked as it depends on this PR. If you're not able to merge this is in for any reason, we can always release a custom version of the server that will work with our skin.

denilsonsa commented 8 years ago

There is one piece of polish missing from this pull request: the size shows up as "Size: -1 x -1" in the skin list. It could be changed to "Size: dynamic" (or "Size: flexible").

mike-koch commented 8 years ago

@denilsonsa I opened a pull request on your fork that handles displaying "Dynamic" if the size is -1 by -1. Once that gets merged in it (should) appear on this pull request.

Funbit commented 8 years ago

Hi guys! (@mkoch227, @denilsonsa) Thank you for mentioning me in this thread. I'm sorry that I've been "ignoring" ETS2 world for a couple of months now.. Really busy right now :( But, I will definitely have some time this weekend, at least to release the updated version of the server. And I will. So please wait for a couple of days...

Thank you, Funbit

Funbit commented 8 years ago

Hi @mkoch227 @denilsonsa @Phil0499 I have merged your pull requests and updated the package to 3.0.6 version. Could you please test it to see if it reflects your needs? Thanks

mike-koch commented 8 years ago

@Funbit it looks like the check for displaying "Dynamic" (instead of -1 x -1) on the skin select screen was removed. Was this intentional? (https://github.com/Funbit/ets2-telemetry-server/commit/83f90641181cb8f4494f07a09a036fc8284cbb43#diff-8336fb20bf788100cf54bc0332200ef8L48)

2015-10-10 13_17_00-start

Funbit commented 8 years ago

@mkoch227 No, it wasn't intentional, it's just you edited wrong file :) Please do not edit anything inside /server/* directory, all files inside this directory are auto-generated and eventually get replaced by the files, compiled from the /source/* directory. All HTML and TS (.js files gets replaced by the compiled .ts files) source files are located inside /source/Funbit.Ets.Telemetry.Mobile/* directory.

I've created a new 3.0.7 version, please take a look if it's ok.

And thanks for your contributions! Really appreciate it.

mike-koch commented 8 years ago

Ah, I didn't know that. Thanks for fixing it :smile:

denilsonsa commented 8 years ago

I'm away from my computer for a couple of days.

By the way, @funbit, have you seen my reply on the forum? Your mod for capturing the map is crashing on the latest versions of ETS2. I have a wild guess it might be because the game now supports numbered GPS destinations.

Also, do you know if it is possible to port the telemetry API to Linux and Mac? Do you have links to documentation? (I know the telemetry server code is written in .net and uses some Windows hooks; I'm talking about the game DLL.) If it is possible, I thought about writing a cross-platform telemetry server, but I'm not sure I will do it (after all, my Linux machine has an Intel video card that struggles with the game; and I don't have access to any Mac machine).

In a few days I can give more feedback, if any.

[Sent from my Android phone.]

ask-compu commented 7 years ago

@denilsonsa i have a GTX 1050 card and would be willing to provide help in linux development for this

denilsonsa commented 7 years ago

@ask-compu You might start from here: http://modding.scssoft.com/wiki/Documentation/Engine/SDK/Telemetry

Do you have C/C++ knowledge? You may try porting the existing telemetry example to Linux and see if it works. Or even check the forums if someone tried it already.

Personally, I've been quite busy, and I don't have a gaming computer anymore.

Good luck! And I think this issue is the wrong place to discuss this kind of topic.

ask-compu commented 7 years ago

Sorry I'm a python person

Sent from my Verizon, Samsung Galaxy smartphone

-------- Original message -------- From: Denilson Sá Maia notifications@github.com Date: 12/23/16 2:24 AM (GMT-05:00) To: Funbit/ets2-telemetry-server ets2-telemetry-server@noreply.github.com Cc: Compu hotwheels14901@me.com, Mention mention@noreply.github.com Subject: Re: [Funbit/ets2-telemetry-server] Allows disabling the auto-scaling feature (#66)

@ask-compu You might start from here: http://modding.scssoft.com/wiki/Documentation/Engine/SDK/Telemetry Do you have C/C++ knowledge? You may try porting the existing telemetry example to Linux and see if it works. Or even check the forums if someone tried it already. Personally, I've been quite busy, and I don't have a gaming computer anymore. Good luck! And I think this issue is the wrong place to discuss this kind of topic.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Funbit/ets2-telemetry-server","title":"Funbit/ets2-telemetry-server","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/Funbit/ets2-telemetry-server"}},"updates":{"snippets":[{"icon":"PERSON","message":"@denilsonsa in #66: @ask-compu You might start from here: http://modding.scssoft.com/wiki/Documentation/Engine/SDK/Telemetry\r\n\r\nDo you have C/C++ knowledge? You may try porting the existing telemetry example to Linux and see if it works. Or even check the forums if someone tried it already.\r\n\r\nPersonally, I've been quite busy, and I don't have a gaming computer anymore.\r\n\r\nGood luck! And I think this issue is the wrong place to discuss this kind of topic."}],"action":{"name":"View Pull Request","url":"https://github.com/Funbit/ets2-telemetry-server/pull/66#issuecomment-268950498"}}}