Funbit / ets2-telemetry-server

ETS2/ATS Telemetry Web Server + Mobile Dashboard
GNU General Public License v3.0
623 stars 206 forks source link

SDK 1.6 available #89

Open jammerxd opened 8 years ago

jammerxd commented 8 years ago

Hello, How would one go about updating the sdk to 1.6?

Funbit commented 8 years ago

Hello, I don't see anything new in the 1.6, they just added a constant related to the ATS version. The rest stuff hasn't changed (at least looking at the headers). This is the release I'm talking about: http://modding.scssoft.com/wiki/Documentation/Engine/SDK/Telemetry

jammerxd commented 8 years ago

Was wondering if using that might help the trailer reset issue. I have also figured out WHY it is happening.

When the trailer is disconnected, the navigation distance briefly gets reset to 0 by SCS, but it's only for a fraction of a second. When the trailer is reconnected, the navigation distance resumes it's calculation.

Funbit commented 8 years ago

Yea, I know the root of the problem as well. The most robust way to fix it would be to temporarily buffer job information before reset (as explained here https://github.com/Funbit/ets2-telemetry-server/issues/86 ). I'm sorry for the next release delay, it is a very busy month for me. Trying to do the best.

jammerxd commented 8 years ago

Is that the root of the issue as I explained above or can you go into more details(I might be able to make a solution for you)?

Funbit commented 8 years ago

Pretty much it is, but I believe I will manage to fix it today and release a new version with the updated plugin. But testing is what takes time most.. :(

jammerxd commented 8 years ago

If you get that new version released, I will test it for you since I've got some major projects that rely on the ability to detect when a job is truly done. :)

Funbit commented 8 years ago

That would help, thanks. I'll post here as soon as the fix is ready for testing then!

jammerxd commented 8 years ago

Actually, I did manage to fix it! I made the new job statement it's own if statement instead of else if then I took the job finished section and added it to the end of the paused event and added a check to see if the game was paused and bam! problem solved! Now as long as people are NOT within 500m when they disconnect their trailer AND pause the game, everything should be fine!

Funbit commented 8 years ago

Glad to hear that, but it would better to fix the plugin anyway :)

Funbit commented 8 years ago

@dualznz, @jammerxd server-3.2.6-test.zip Could you please test this version? (just overwrite the files from 3.2.5 version) Thanks

dualznz commented 8 years ago

sure no problem ill test this out tonight

dualznz commented 8 years ago

na the constant still resets on trailer disconnect, i just teseed it in both platforms, running 3.2.6 test

Funbit commented 8 years ago

@dualznz Hmm, are you sure? The job info should reset when you disconnect the trailer, however it must restore as soon as you connect it back. Also, can you please confirm that plugin DLL files were overwritten? The bug fix was inside the DLLs...

dualznz commented 8 years ago

righto ill reset the dll extensions

dualznz commented 8 years ago

ok well yup i can confirm it is allowing the reload of the data fine.

Funbit commented 8 years ago

Okay, thank you, I will include this fix in the next release then.