search

FunctionStream / function-stream

Function Stream - Event-streaming function platform based on Apache Pulsar and WebAssembly
Apache License 2.0
40 stars 16 forks source link

refactor: update AddFunc.vue to composition API #91

Closed GiorunoGiovanna closed 3 years ago

Akhil-Yuan commented 3 years ago

Thank you for PR, but there are still some problems.

First, I think the style needs some modifications. Several input boxes have inconsistent widths that make them look strange. You can also adjust the margins between text and input boxes.

Second, you can write together code that handles the same logic in the Vue file, which will makes the code more readable. This is also the reason why we use composition API instead of option API.

GiorunoGiovanna commented 3 years ago

I recommend creating a new branch to manage commits each time you develop a PR, and synchronizing the main branch of your own repository in a timely manner to prevent redundant commits like the one in this PR.

But for now, you don't have to change the branch in this PR. You can follow the way above for future development.

OK, thank you for your advice