FundRequest / vesting-wallets

Vesting Wallets in Solidity
6 stars 1 forks source link

An in-range update of ganache-cli is breaking the build 🚨 #12

Open greenkeeper[bot] opened 5 years ago

greenkeeper[bot] commented 5 years ago

The devDependency ganache-cli was updated from 6.1.8 to 6.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ganache-cli is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **continuous-integration/travis-ci/push:** The Travis CI build failed ([Details](https://travis-ci.org/FundRequest/vesting-wallets/builds/456178401?utm_source=github_status&utm_medium=notification)).

Commits

The new version differs by 28 commits.

  • 93dadb1 6.2.0
  • 4759eab Update ganache-core to 2.3.0
  • d84c9e6 6.2.0-beta.0
  • 1c80923 move these dev dependencies to devDependencies
  • 17a7de7 ignore perf dir when publishing to npm
  • 27cda62 Merge branch 'develop'
  • 4a25106 Update docker build to use shrinkwrap file and node 10-lts
  • ed0c27e shrinkwrap deps
  • 671824a Update ganache-core to beta
  • cf4384e Merge pull request #581 from martianov/add_time_to_cli_args
  • a89bd86 add time arg to readme
  • f598676 Merge branch 'develop' into add_time_to_cli_args
  • 8d3e958 Improve readme formatting
  • 3f6ac8e Replace bit.ly link with direct link in readme
  • 8215ccf Add Option for HTTP Server keepAliveTimeout (#583)

There are 28 commits in total.

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 6.1.8 your tests are passing again. Downgrade this dependency 📌.

greenkeeper[bot] commented 5 years ago

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 3 commits.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 3 commits.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 6 commits.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 14 commits.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v6.2.5 - Hot Fix 🔥

Release Highlights

Fixes an issue where RPC calls to net_version might return "undefined" when the provider is configured to use forking. PR: trufflesuite/ganache-core/issues/264

Commits

The new version differs by 21 commits.

  • 3db03a6 Merge branch 'develop'
  • 24f4454 6.2.5
  • 5aa71f6 bump ganache-core to v2.3.3
  • c4c11ee Sync supported methods with ganache-core
  • a558e9c Sync docs with ganache-core
  • a7ff3c0 Make sure code sections are highlighted
  • 2a782ba Improve readme by fixing typos and adding clarifications (#605)
  • c8b8733 6.2.4
  • 58ba804 Update ganache-core to 2.3.2
  • cc1ba62 6.2.4-beta.2
  • 366c194 Update to ganache-core@2.3.2-beta.6
  • b9b7622 6.2.4-beta.1
  • 4b5be99 6.2.4-beta.0
  • 06f2422 Switch back to webpacking ganache-cli (#606)
  • debda3d Add blockTime option to docs

There are 21 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 24 commits.

  • 6517054 6.3.0
  • 77cc1d1 Update ganache-core to v2.4.0
  • ec3d325 Update README.md to clarify that the accounts option accepts a balance key (#616)
  • 3db03a6 Merge branch 'develop'
  • 24f4454 6.2.5
  • 5aa71f6 bump ganache-core to v2.3.3
  • c4c11ee Sync supported methods with ganache-core
  • a558e9c Sync docs with ganache-core
  • a7ff3c0 Make sure code sections are highlighted
  • 2a782ba Improve readme by fixing typos and adding clarifications (#605)
  • c8b8733 6.2.4
  • 58ba804 Update ganache-core to 2.3.2
  • cc1ba62 6.2.4-beta.2
  • 366c194 Update to ganache-core@2.3.2-beta.6
  • b9b7622 6.2.4-beta.1

There are 24 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 29 commits.

  • 58588c3 6.4.0
  • 196d3ab Add ganache-core --hardfork (-k) option and set default to "petersburg"(#629)
  • 11228a1 Update ganache-core to v2.5.1
  • 181118a Update snapshot documentation to match core docs (#628)
  • 0e57f9e Fix CLI logo in README.md when used outside github
  • 6517054 6.3.0
  • 77cc1d1 Update ganache-core to v2.4.0
  • ec3d325 Update README.md to clarify that the accounts option accepts a balance key (#616)
  • 3db03a6 Merge branch 'develop'
  • 24f4454 6.2.5
  • 5aa71f6 bump ganache-core to v2.3.3
  • c4c11ee Sync supported methods with ganache-core
  • a558e9c Sync docs with ganache-core
  • a7ff3c0 Make sure code sections are highlighted
  • 2a782ba Improve readme by fixing typos and adding clarifications (#605)

There are 29 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 31 commits.

  • 44a1d6b 6.4.1
  • 0240ded Update ganache-core to v2.5.3
  • 58588c3 6.4.0
  • 196d3ab Add ganache-core --hardfork (-k) option and set default to "petersburg"(#629)
  • 11228a1 Update ganache-core to v2.5.1
  • 181118a Update snapshot documentation to match core docs (#628)
  • 0e57f9e Fix CLI logo in README.md when used outside github
  • 6517054 6.3.0
  • 77cc1d1 Update ganache-core to v2.4.0
  • ec3d325 Update README.md to clarify that the accounts option accepts a balance key (#616)
  • 3db03a6 Merge branch 'develop'
  • 24f4454 6.2.5
  • 5aa71f6 bump ganache-core to v2.3.3
  • c4c11ee Sync supported methods with ganache-core
  • a558e9c Sync docs with ganache-core

There are 31 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v6.4.2 - Gas Exactimation 📏

 Highlights    How to Upgrade    Changelog    Related Releases 


A long-standing issue with Ganache has been the fact that we haven't returned EIP-114 compliant gas estimations, AKA the "1/64ths rule". This caused our gas estimates to be too low in cases where a transaction executed opcodes that are subject to this EIP. This in turn was the cause of many frustrations, especially in situations where tools would use gas estimations in transactions without allowing the user to intercept or change the transaction's supplied gas.

Highlights

EIP-114 mandates that certain stackdepth-creating opcodes withhold 1/64th of remaining gas from the stack they create. This has two non-obvious effects:

  1. The gas required for a successful transaction can be greater than the actual gas spent. This is similar to how gas refunds behave.
  2. The extra gas required for a successful transaction varies depending on the transaction's initial gas amount!

Let's say we want to run the following example transaction (note: this transaction is nonsensical and is intended only to illustrate the 1/64ths rule):

DEPTH OPCODE OP FEE
0 PUSH1 3
0 CALL 700
1 ADD 3
1 EXPENSIVE 10000
1 RETURN 0
0 POP 2
0 STOP 0
  Total Gas: 10708

This transaction would cost exactly 10708 gas. However, if you attempted to run this transaction by supplying only 10708 gas it would fail with an "out of gas" exception when it gets to the EXPENSIVE opcode!

The reason for this failure is that the opcode CALL is subject to EIP-114. Here's a breakdown of how this gas is used:

DEPTH OPCODE GAS AVAILABLE OP FEE 1⁄64 WITHHELD
0 PUSH1 10708 3  
0 CALL 10705 700 156
1 ADD 9849 3  
1 EXPENSIVE 9846 10000  
  REVERT OOG    

Instead of 10005 gas available (10705 gas available − 700 op fee) at the ADD opcode,
only 9849 is actually available due to the "withheld" 1/64th: 10005 − FLOOR( 10005 ⁄ 64 ) = 9849; we are now 154 gas short!

All we need to do now is increase our supplied gas by 154, right? Let's see what happens now:

DEPTH OPCODE GAS AVAILABLE OP FEE 1⁄64 WITHHELD
0 PUSH1 10862 3  
0 CALL 10859 700 158
1 ADD 10001 3  
1 EXPENSIVE 9998 10000  
  REVERT OOG    

We still don't have enough gas! The amount withheld increased by 2 gas because the gas supplied to the transaction increased as well!

Because the 1/64ths rule gets applied to the gas remaining, which has increased since our first estimate, 2 more gas gets withheld, resulting in an OOG error!

Now, let's run the same transaction one more time, this time using the result of our new gas estimation algorithm:

DEPTH OPCODE GAS AVAILABLE OP FEE 1⁄64 WITHHELD
0 PUSH1 10864 3  
0 CALL 10861 700 158
1 ADD 10003 3  
1 EXPENSIVE 10000 10000  
1 RETURN 0 0 −158
0 POP 158 2  
0 STOP 156 0  
    156    

It works! Notice that 156 gas was unspent at the end of the transaction, but had we provided even 1 less gas the transaction would have resulted in an "out of gas" exception at EXPENSIVE opcode.


This series of simplified examples attempts to provide a high-level overview of the 1/64th gas estimation calculation. To correctly estimate gas on any contract, we must consider how the gas withheld at any nested stack depth/frame affects the gas needed outside of its execution context.

It's a tricky problem to solve. Some implementations of gas estimation after EIP-114 use interval halving (binary search) by running the transaction through the EVM until the gas estimation converges. This seemed like an unnecessarily CPU-intensive approach to the problem, and we set out to find a (theoretically) more performant, and perfectly accurate, way of estimating gas (which we now refer to as "gas exactimation" here at Truffle).

If you find that any of your transactions are running in to unexpected OOG errors please let us know by filing an issue.


We are especially proud of this algorithm, and we are even more proud of the brilliant minds that went into its creation. Thank you Nick Paterno (@nicholasjpaterno), Amal Sudama (@cds-amal), Chris Cowell (@ccowell), Mike Seese (@seesemichaelj), Benjamin Burns (@benjamincburns), and David Murdoch (@davidmurdoch) for all the work you've put in to this release!

We'll follow up with a detailed blog post on the algorithm itself in the coming weeks.

How to Upgrade

Upgrade to the latest version of ganache-cli by running:

npm

npm uninstall -g ganache-cli
npm install -g ganache-cli@latest

yarn

yarn global remove ganache-cli
yarn global add ganache-cli@latest

Changelog

Bug Fixes

Documentation

Related Releases


💖 The Truffle Team

Commits

The new version differs by 40 commits.

  • 1ebd8a8 6.4.2
  • a7ff6de Update ganache-core to v2.5.4
  • d539557 6.4.2-beta.0
  • 773be25 Merge branch 'beta' into tmp
  • 219a8f1 Update ganache-core to v2.5.4-beta.2
  • 44a1d6b 6.4.1
  • 0240ded Update ganache-core to v2.5.3
  • 58588c3 6.4.0
  • 196d3ab Add ganache-core --hardfork (-k) option and set default to "petersburg"(#629)
  • 11228a1 Update ganache-core to v2.5.1
  • 181118a Update snapshot documentation to match core docs (#628)
  • 0e57f9e Fix CLI logo in README.md when used outside github
  • 6517054 6.3.0
  • 77cc1d1 Update ganache-core to v2.4.0
  • ec3d325 Update README.md to clarify that the accounts option accepts a balance key (#616)

There are 40 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 44 commits.

  • c75a27e 6.4.3
  • b38ffc7 Update ganache-core to v2.5.5
  • 4bc3901 6.4.3-beta.0
  • 78136f3 Update ganache-core to v2.5.5-beta.0
  • 1ebd8a8 6.4.2
  • a7ff6de Update ganache-core to v2.5.4
  • d539557 6.4.2-beta.0
  • 773be25 Merge branch 'beta' into tmp
  • 219a8f1 Update ganache-core to v2.5.4-beta.2
  • 44a1d6b 6.4.1
  • 0240ded Update ganache-core to v2.5.3
  • 58588c3 6.4.0
  • 196d3ab Add ganache-core --hardfork (-k) option and set default to "petersburg"(#629)
  • 11228a1 Update ganache-core to v2.5.1
  • 181118a Update snapshot documentation to match core docs (#628)

There are 44 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 50 commits.

There are 50 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v6.4.5 - Banana Pudding 🍌

 Highlights    How to Upgrade    Changelog    Related Releases 


We're moving to a betalatest release pipeline, where all non-hotfix changes are first released in a beta before being promoted to a stable release.

We'd love it if you'd start using the latest betas and let us know early and often if you find any bugs or regressions!

Highlights

This version of ganache-cli features the latest and greatest gas exactimation algorithm. While the previous algorithm works well in most cases and was heavily tested, it relied on several assumptions we later found to be incorrect. Gas exactimation 2.0 now makes ZERO assumptions, and returns an exactimation in O(1), compared with O(log n) in geth, parity, etc!

Some notable improvements you might like:

  • Completely rewritten without recursion
  • Approximately 20% faster and 33% less code
  • Works with CREATE2

Stay tuned for a full featured blog post explaining the algorithm and a "Deep Dive" workshop at TruffleCon 2019!


In case you missed it, we're holding TruffleCon 2019 August 2 - 4 at Microsoft's campus in Redmond, WA! And it'll be awesome. You should be there.
 Get Tickets (only $99!)  


How to Upgrade

Upgrade to the latest version of ganache-cli by running:

npm

npm uninstall ganache-cli -g
npm install ganache-cli@latest -g

yarn

yarn global remove ganache-cli
yarn global add ganache-cli@latest

Changelog

Bug Fixes

Maintenance

Related Releases


💖 The Truffle Team

Commits

The new version differs by 54 commits.

There are 54 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 61 commits.

There are 61 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 67 commits.

  • d73dd23 6.5.1
  • 94906af 6.5.1-beta.0
  • d8e605d Update ganache-core to v2.6.1-beta.0
  • b6cd7cd Merge branch 'master' into develop
  • 84589e1 6.5.0
  • 4e37506 Update ganache-core to v2.6.0
  • aad7601 chore: update packages (bn.js, source-map-support, yargs) (#661)
  • 9f6f842 Display Available Account addresses as EIP-55 checksum addresses when ganache-cli starts (#659)
  • 998624b 6.4.6-beta.0
  • cea30f2 Merge branch 'develop' into beta
  • e48a204 Update ganache-core to v2.5.8-beta.0
  • 646f279 Merge branch 'master' into develop
  • 499d13f 6.4.5
  • 89f6002 Update ganache-core to v2.5.7
  • f3b1d58 Update README.md (#656)

There are 67 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 74 commits.

  • 9a2a821 6.6.0
  • deff0c4 Update ganache-core to v2.7.0
  • 76c930e 6.6.0-beta.0
  • b1884ba Update ganache-core to v2.7.0-beta.0
  • 664516e Merge branch 'master' into develop
  • d73dd23 6.5.1
  • 686e5db fix: account_keys_path option doesn't work (#666)
  • f85944f Add eth_signTypedData to list of supported methods in README
  • 94906af 6.5.1-beta.0
  • d8e605d Update ganache-core to v2.6.1-beta.0
  • b6cd7cd Merge branch 'master' into develop
  • 84589e1 6.5.0
  • 4e37506 Update ganache-core to v2.6.0
  • aad7601 chore: update packages (bn.js, source-map-support, yargs) (#661)
  • 9f6f842 Display Available Account addresses as EIP-55 checksum addresses when ganache-cli starts (#659)

There are 74 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 81 commits.

  • 0366a9d 6.7.0
  • 5de01e8 Update ganache-core to v2.8.0
  • ae67b0d Merge branch 'master' into develop
  • 928dcae fix: fix forked chain so that it outputs the fork block number
  • b5863d2 Fix Forked Chain cli output to include the fork block number
  • f923ac7 6.7.0-beta.0
  • 83e1d87 Update ganache-core to v2.8.0-beta.0
  • 9a2a821 6.6.0
  • deff0c4 Update ganache-core to v2.7.0
  • 76c930e 6.6.0-beta.0
  • b1884ba Update ganache-core to v2.7.0-beta.0
  • 664516e Merge branch 'master' into develop
  • d73dd23 6.5.1
  • 686e5db fix: account_keys_path option doesn't work (#666)
  • f85944f Add eth_signTypedData to list of supported methods in README

There are 81 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v6.8.2 - Hotfix 🔥

 Highlights    How to Upgrade    Changelog    Related Releases 


We're moving to a betalatest release pipeline, where all non-hotfix changes are first released in a beta before being promoted to a stable release.

We'd love it if you'd start using the latest betas and let us know early and often if you find any bugs or regressions!

Highlights

The previous release, v6.8.1, changed the way chainId's (the v value) were handled for raw transactions which in turn was preventing them from being accepted in certain situations. This fixes this issue and reverts the change that enabled EIP-155 replay protection in order to preserve backwards compatibility. Additionally, the mismatch of between ganache-cli's hardcoded chainId and its default net_version caused metamask signed transactions to always fail. Ganache-cli will accept any v value as it used to prior to v6.8.2.

This behavior will change in the next major release of ganache-cli and the default behavior will be to validate the v value of raw transactions against the configured chainId.


How to Upgrade

Upgrade to the latest version of ganache-cli by running:

npm

npm uninstall ganache-cli -g
npm install ganache-cli@latest -g

yarn

yarn remove ganache-cli -g
yarn add ganache-cli@latest -g

Changelog

Bug Fixes

Related Releases


💖 The Truffle Team

Commits

The new version differs by 95 commits.

  • ccba143 6.8.2
  • 9f788a0 Update ganache-core to v2.9.2
  • a7eba57 Update default hardfork to istanbul
  • 15f2e76 Merge branch 'develop' of github.com:trufflesuite/ganache-cli into develop
  • ac15fff 6.8.1
  • 7c2202f Update sub-dependencies
  • 0bd23a3 Update ganache-core to v2.9.1
  • b12e988 docs: improve db_path documentation (#693)
  • 686ddf2 Update gasLimit type docs (#695)
  • 1c8d2bc 6.8.1-beta.0
  • 0e24de3 UPdate ganache-core to v2.9.1-beta.0
  • 360a0b3 Expose callGasLimit option to cli (#681)
  • 2378ed1 6.8.0-istanbul.0
  • 96041bb Istanbul support; Update ganache-core to v2.9.0-istanbul.0
  • 0366a9d 6.7.0

There are 95 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v6.9.0 – Muir Glacier Mint 🏔️ 🍬 🌿

 Highlights    How to Upgrade    Changelog    Related Releases 


We're moving to a betalatest release pipeline, where all non-hotfix changes are first released in a beta before being promoted to a stable release.

We'd love it if you'd start using the latest betas and let us know early and often if you find any bugs or regressions!

Highlights

Muir Glacier Mint 🏔️ 🍬 🌿

This release updates ganache-cli's default hardfork to muirGlacier, inline with Ethereum's mainnet and testnet's. As many of you know, the Muir Glacier hardfork is a minor adjustment in the way difficulty was calculated; it was intended only to delay the 'ice age' (by 52 million seconds (~611 days)). Since ganache-core (the underlying engine) mines with 0 difficulty, users can expect functionality to remain identical to the istanbul hardfork.

Finally, this beta version contains a (potential? 😅) fix to work around an open Merkle Patricia Tree bug from 2016 ethereumjs/merkle-patricia-tree#12! If you do still get the dreaded TypeError: Cannot read property 'pop' of undefined please file an issue with all the details!


How to Upgrade

Upgrade to the latest version of ganache-cli by running:

npm

npm uninstall ganache-cli -g
npm install ganache-cli@beta -g

yarn

yarn global remove ganache-cli
yarn global add ganache-cli@beta

Changelog

Features

Bug Fixes

Maintenance

Related Releases


💖 The Truffle Team

Commits

The new version differs by 105 commits.

  • ce82e50 6.9.0
  • 2342bf7 Update default hardfork to muirGlacier (#713)
  • 33b9b0a Update ganache-core to v2.10.1
  • f0b1eee Update ganache-core to v2.10.0
  • 3737c4e misc: update hardfork default in cli "describe" to istanbul (#711)
  • 9319f49 6.8.3-beta.0
  • bf1c134 Update ganache-core to v2.9.3-beta.0
  • 7a0e737 Merge branch 'develop' into beta
  • ccba143 6.8.2
  • 9f788a0 Update ganache-core to v2.9.2
  • a7eba57 Update default hardfork to istanbul
  • 95b53a4 6.8.2-beta.0
  • e3ebf6c Update ganache-core to v2.9.2-beta.1
  • 15f2e76 Merge branch 'develop' of github.com:trufflesuite/ganache-cli into develop
  • ac15fff 6.8.1

There are 105 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 108 commits.

  • 307db6f 6.9.1
  • 4adb3ea Update ganache-core to v2.10.2
  • 424bfe5 Add hd_path to cli (#704)
  • ce82e50 6.9.0
  • 2342bf7 Update default hardfork to muirGlacier (#713)
  • 33b9b0a Update ganache-core to v2.10.1
  • f0b1eee Update ganache-core to v2.10.0
  • 3737c4e misc: update hardfork default in cli "describe" to istanbul (#711)
  • 9319f49 6.8.3-beta.0
  • bf1c134 Update ganache-core to v2.9.3-beta.0
  • 7a0e737 Merge branch 'develop' into beta
  • ccba143 6.8.2
  • 9f788a0 Update ganache-core to v2.9.2
  • a7eba57 Update default hardfork to istanbul
  • 95b53a4 6.8.2-beta.0

There are 108 commits in total.

See the full diff