Open mpyatishev opened 10 years ago
On my local machine all tests passes. It looks like the case of the difference between my environment settings and environment for Travis. How can I check it?
i'm also interested to make this happen. i cloned your repo but i'm experiencing the same errors as in the travis log on my local machine. what i did:
mkvirtualenv pa
git clone git@github.com:mpyatishev/django-paypal-adaptive.git
cd django-paypal-adaptive
pip install -r requirements_test.txt
python runtests.py
...
----------------------------------------------------------------------
Ran 34 tests in 0.386s
FAILED (errors=6)
It turned out that the Money.__init__()
does not check arguments to None, and that broke the tests. I made the appropriate pull-request in py-moneyed.
@mpyatishev That seems like something that should be changed in django-paypal-adaptive. If py-moneyed doesn't accept None
as amount, Decimal('0.0')
should be passed instead.
Btw, no one from FundedByMe has been active here for a few months, I believe they are moving away from Paypal Adaptive and thus it's not likely that they'll keep maintaining this package or accept pull requests. I'd suggest get a conversation going about someone else taking over those responsibilities.
Perhaps you're right.
@antonagestam do you know where they are moving to? perhaps http://www.mangopay.com? what other services support the scenarios paypal adaptive payment supports: parallel, preapproval, chained etc.? (sorry for the offtopic)
antonagestam, On my opinion its not matter because in Money.__init__()
it will converted to Decimal('0.0')
anyway.
@mpyatishev In this particular case it's probably fine but I'd say it's bad practice to use floats when you need higher precision for instance, take this example:
>>> i = 0.00001
>>> i
1e-05
>>> from decimal import Decimal
>>> d = Decimal(i)
>>> d
Decimal('0.000010000000000000000818030539140313095458623138256371021270751953125')
See my point?
May I politely ask, what the state of this pull request is?
@jakob-o - We are no longer using PayPal or this library. So are no longer planning on maintaining it. We are now maintaining the django-mangopay library instead.
If you are interested in taking over as the official owner let me know.
@mpyatishev The tests are failing.