Closed 7vs closed 5 years ago
Merging #177 into master will decrease coverage by
0.03%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
- Coverage 80.92% 80.88% -0.04%
==========================================
Files 39 39
Lines 2364 2365 +1
Branches 149 149
==========================================
Hits 1913 1913
- Misses 302 303 +1
Partials 149 149
Impacted Files | Coverage Δ | |
---|---|---|
src/jackdaw/test/fixtures.clj | 55.33% <0%> (-0.38%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5420835...f5448a2. Read the comment docs.
Merging #177 into master will increase coverage by
0.7%
. The diff coverage is87.5%
.
@@ Coverage Diff @@
## master #177 +/- ##
=========================================
+ Coverage 80.76% 81.46% +0.7%
=========================================
Files 39 39
Lines 2365 2369 +4
Branches 149 149
=========================================
+ Hits 1910 1930 +20
+ Misses 306 290 -16
Partials 149 149
Impacted Files | Coverage Δ | |
---|---|---|
src/jackdaw/test/fixtures.clj | 66.88% <87.5%> (+11.54%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 87f0e5d...a4147bb. Read the comment docs.
Issue #176 was already fixed by #179 although the fix was not backed by a unit test. @7vs and I (@cddr) had already begun working on this when @kidpollo submitted #179 but figured we'd continue as this PR back-fills a unit-test for the feature and also adds the ability for the user of the fixture to supply optional parameters, and an optional
reset-fn
which allows the unit test to check that the error case is handled with an informative exception (the StreamsResetter quite often fails in a dev environment when the state can easily become inconsistent but the error message usually contains enough information about what to do to resolve the situation.