search

FundingCircle / jackdaw

A Clojure library for the Apache Kafka distributed streaming platform.
https://fundingcircle.github.io/jackdaw/
BSD 3-Clause "New" or "Revised" License
369 stars 80 forks source link

no need to pass in the cmd in every command handler #183

Closed AndreaCrotti closed 4 years ago

AndreaCrotti commented 5 years ago

The cmd argument was always passed in every handler but never used. Since you already know what command you are handling you would probably never need it either, so it can be simplified.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cee3aba). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #183   +/-   ##
=========================================
  Coverage          ?   79.45%           
=========================================
  Files             ?       41           
  Lines             ?     2511           
  Branches          ?      150           
=========================================
  Hits              ?     1995           
  Misses            ?      366           
  Partials          ?      150
Impacted Files Coverage Δ
src/jackdaw/test/commands/watch.clj 100% <ø> (ø)
src/jackdaw/test/commands.clj 100% <100%> (ø)
src/jackdaw/test/commands/write.clj 92.68% <100%> (ø)
src/jackdaw/test/commands/base.clj 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cee3aba...0da20e5. Read the comment docs.