search

FundingCircle / jackdaw

A Clojure library for the Apache Kafka distributed streaming platform.
https://fundingcircle.github.io/jackdaw/
BSD 3-Clause "New" or "Revised" License
369 stars 80 forks source link

pr template and add unreleased section #187

Closed AndreaCrotti closed 5 years ago

AndreaCrotti commented 5 years ago
codecov[bot] commented 5 years ago

Codecov Report

Merging #187 into master will increase coverage by 0.12%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   81.62%   81.75%   +0.12%     
==========================================
  Files          39       39              
  Lines        2373     2373              
  Branches      149      149              
==========================================
+ Hits         1937     1940       +3     
+ Misses        287      284       -3     
  Partials      149      149
Impacted Files Coverage Δ
src/jackdaw/serdes/edn.clj 92.3% <0%> (+11.53%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a0c4cb9...0f04eab. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cee3aba). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #187   +/-   ##
=========================================
  Coverage          ?   81.75%           
=========================================
  Files             ?       39           
  Lines             ?     2373           
  Branches          ?      149           
=========================================
  Hits              ?     1940           
  Misses            ?      284           
  Partials          ?      149

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cee3aba...746e9fa. Read the comment docs.

creese commented 5 years ago

doc is the default path created by Leiningen. Why change it?

AndreaCrotti commented 5 years ago

@creese just because in the github documentation, the pull request template had to be in the docs directory, and having both didn't make sense. https://help.github.com/en/articles/creating-a-pull-request-template-for-your-repository

Ah actually I just noticed I could have also used .github, though, so I can move it there and revert the doc->docs change.

AndreaCrotti commented 5 years ago

Ok @creese I moved it to .github and restored the previous .doc directory