search

FundingCircle / jackdaw

A Clojure library for the Apache Kafka distributed streaming platform.
https://fundingcircle.github.io/jackdaw/
BSD 3-Clause "New" or "Revised" License
369 stars 80 forks source link

Skip deploy_snapshots job for external contributors #194

Closed DaveWM closed 4 years ago

DaveWM commented 4 years ago

Currently, external contributors can never merge their PRs because the circleci deploy_snapshots job will always fail. This is because it relies on the CLOJARS_USERNAME and CLOJARS_PASSWORD env vars, which are not injected for PRs from forks (the "Pass secrets to builds from forked pull requests" option is disabled).

In circleci, it's not possible to conditionally run a step based on an env var, so this PR just updates the deploy_snapshot job to do nothing if CLOJARS_USERNAME isn't set.

codecov[bot] commented 4 years ago

Codecov Report

Merging #194 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   81.43%   81.43%           
=======================================
  Files          40       40           
  Lines        2391     2391           
  Branches      149      149           
=======================================
  Hits         1947     1947           
  Misses        295      295           
  Partials      149      149

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f404699...6ad9681. Read the comment docs.