FundingCircle / jackdaw

A Clojure library for the Apache Kafka distributed streaming platform.
https://fundingcircle.github.io/jackdaw/
BSD 3-Clause "New" or "Revised" License
369 stars 80 forks source link

Tidy up the rest-proxy transport #205

Closed cddr closed 4 years ago

cddr commented 4 years ago

I'd like to add a capability to the rest-proxy transport that allows a test-author to start consuming the specified topics from the beginning rather than the end. However before getting to that, I wanted to tidy up a few niggling issues so this PR tries to address those.....

codecov[bot] commented 4 years ago

Codecov Report

Merging #205 into master will increase coverage by 0.13%. The diff coverage is 82.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   79.13%   79.27%   +0.13%     
==========================================
  Files          41       41              
  Lines        2531     2543      +12     
  Branches      151      150       -1     
==========================================
+ Hits         2003     2016      +13     
  Misses        377      377              
+ Partials      151      150       -1
Impacted Files Coverage Δ
src/jackdaw/streams/interop.clj 80.28% <100%> (ø) :arrow_up:
src/jackdaw/test/transports/rest_proxy.clj 84.23% <81.81%> (+1.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c7ed25...452e810. Read the comment docs.