FundingCircle / jackdaw

A Clojure library for the Apache Kafka distributed streaming platform.
https://fundingcircle.github.io/jackdaw/
BSD 3-Clause "New" or "Revised" License
369 stars 80 forks source link

Null-able ProducerRecord and RecordMetadata members #220

Closed bobby closed 4 years ago

bobby commented 4 years ago

Checklist

codecov[bot] commented 4 years ago

Codecov Report

Merging #220 into master will decrease coverage by 0.38%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
- Coverage   79.97%   79.59%   -0.39%     
==========================================
  Files          42       42              
  Lines        2597     2597              
  Branches      150      150              
==========================================
- Hits         2077     2067      -10     
- Misses        370      380      +10     
  Partials      150      150
Impacted Files Coverage Δ
src/jackdaw/serdes/edn2.clj 45.45% <0%> (-45.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e34e47e...fc9db9d. Read the comment docs.

bobby commented 4 years ago

@cddr I've added a few tests to exercise these fixes.

cddr commented 4 years ago

@bobby Awesome thanks for that. LGTM :-)