search

FundingCircle / jackdaw

A Clojure library for the Apache Kafka distributed streaming platform.
https://fundingcircle.github.io/jackdaw/
BSD 3-Clause "New" or "Revised" License
369 stars 80 forks source link

[#238] Add divert func #236

Open bn-darindouglass-zz opened 4 years ago

bn-darindouglass-zz commented 4 years ago

Implements [#238]

Checklist

bn-darindouglass-zz commented 4 years ago

I'm open to suggestions on naming; primarily, I'm not sure if sort-by indicates well enough what it does.

EDIT: nevermind, I just combined the two functions.

codecov[bot] commented 4 years ago

Codecov Report

Merging #236 (6d1f18f) into master (057ef7c) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   80.05%   80.09%   +0.03%     
==========================================
  Files          42       42              
  Lines        2753     2758       +5     
  Branches      157      157              
==========================================
+ Hits         2204     2209       +5     
  Misses        392      392              
  Partials      157      157
Impacted Files Coverage Δ
src/jackdaw/streams.clj 83.84% <100.00%> (+0.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 057ef7c...6d1f18f. Read the comment docs.

darin-reify commented 1 year ago

this pr has been replaced by this. feel free to close this pr (as i cannot).