FundingCircle / jackdaw

A Clojure library for the Apache Kafka distributed streaming platform.
https://fundingcircle.github.io/jackdaw/
BSD 3-Clause "New" or "Revised" License
369 stars 80 forks source link

Fixes* every reflection warning #246

Closed 99-not-out closed 4 years ago

99-not-out commented 4 years ago

Will not be popular if you have an open PR!

Would be good to start failing the build on reflection warnings if we can?

codecov[bot] commented 4 years ago

Codecov Report

Merging #246 into master will decrease coverage by 0.01%. The diff coverage is 65.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   81.22%   81.21%   -0.02%     
==========================================
  Files          41       41              
  Lines        2519     2560      +41     
  Branches      149      149              
==========================================
+ Hits         2046     2079      +33     
- Misses        324      332       +8     
  Partials      149      149              
Impacted Files Coverage Δ
src/jackdaw/streams/describe.clj 18.80% <7.40%> (+0.11%) :arrow_up:
src/jackdaw/serdes/avro.clj 89.07% <66.66%> (ø)
src/jackdaw/test.clj 79.71% <75.00%> (+0.29%) :arrow_up:
src/jackdaw/admin.clj 89.09% <77.77%> (+0.10%) :arrow_up:
src/jackdaw/test/transports/kafka.clj 86.04% <88.88%> (+0.10%) :arrow_up:
src/jackdaw/client.clj 79.72% <100.00%> (ø)
src/jackdaw/client/log.clj 44.00% <100.00%> (+2.33%) :arrow_up:
src/jackdaw/client/partitioning.clj 28.20% <100.00%> (+1.88%) :arrow_up:
src/jackdaw/serdes.clj 75.00% <100.00%> (+3.57%) :arrow_up:
src/jackdaw/serdes/avro/confluent.clj 100.00% <100.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d53da3f...2cf0379. Read the comment docs.