search

FundingCircle / jackdaw

A Clojure library for the Apache Kafka distributed streaming platform.
https://fundingcircle.github.io/jackdaw/
BSD 3-Clause "New" or "Revised" License
369 stars 80 forks source link

Is `aleph` really needed under the top-level dependencies? #267

Closed jimpil closed 3 years ago

jimpil commented 3 years ago

Hi there,

Correct me if I'm wrong, but aleph is only needed in a couple of test namespaces. If that's correct, how come it's included as a top-level dependency? There is already a dev profile where it can go, right?

Thanks in advance...

cddr commented 3 years ago

The test machine is part of the public interface and provides support for testing kafka applications. See the docs here. This is what requires the dependency on aleph. If you don't plan on using it, you should be able to exclude aleph when depending on jackdaw in your project.clj.

jimpil commented 3 years ago

Oh I see - thanks a lot for clarifying :+1: