search

FundingCircle / jackdaw

A Clojure library for the Apache Kafka distributed streaming platform.
https://fundingcircle.github.io/jackdaw/
BSD 3-Clause "New" or "Revised" License
369 stars 80 forks source link

Upgrade to Kafka 2.4.1 #270

Closed csenol closed 2 years ago

csenol commented 3 years ago

Checklist

codecov[bot] commented 3 years ago

Codecov Report

Merging #270 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files          41       41           
  Lines        2586     2586           
  Branches      153      153           
=======================================
  Hits         2099     2099           
  Misses        334      334           
  Partials      153      153

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update daa8387...d59232f. Read the comment docs.

csenol commented 3 years ago

Kafka 2.4 is providing new partition assignment strategies such as cooperative-sticky It would be good if jackdaw can catch-up

cddr commented 3 years ago

Might be worth also updating the images used by CI to the corresponding confluent release.

https://github.com/FundingCircle/jackdaw/blob/master/.circleci/config.yml#L44

csenol commented 3 years ago

Thanks for the review. When are you planning to have a release?

cddr commented 3 years ago

I'm no longer an administrator so dunno when someone will be able to get a release out. If you have a pressing need though, you may be able to just override the kafka dependencies in your own project.clj.

mt3593 commented 3 years ago

Any update on this, any administrators able to get a release out?

robert-pierce commented 3 years ago

Following ... we could use the new support for Named class. We are producing graph images of our topologies as a method of documentation, and naming the nodes would be extremely helpful.

dakra commented 3 years ago

fyi, I have merged a few PRs that I needed (including this one) in my fork. I also published it to clojars.

I don't really want to maintain this fork or make something official or anything. I just did it because I needed it personally, maybe it helps you too until @FundingCircle picks development up again.

gphilipp commented 2 years ago

Closing since we upgraded to 2.8.0 via #292