search

FundingCircle / jackdaw

A Clojure library for the Apache Kafka distributed streaming platform.
https://fundingcircle.github.io/jackdaw/
BSD 3-Clause "New" or "Revised" License
368 stars 80 forks source link

Enable naming global-ktable local store #277

Open vmatic opened 3 years ago

vmatic commented 3 years ago

The current implementation doesn't support naming the GlobalKTable store. This pull request adds functionality by extending the protocol IStreamsBuilder and adding a new arity to the existing global-ktable function. Implementation follows the same pattern used to name ktable local stores.

codecov[bot] commented 3 years ago

Codecov Report

Merging #277 into master will increase coverage by 0.03%. The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   81.16%   81.20%   +0.03%     
==========================================
  Files          41       41              
  Lines        2586     2596      +10     
  Branches      153      153              
==========================================
+ Hits         2099     2108       +9     
- Misses        334      335       +1     
  Partials      153      153
Impacted Files Coverage Δ
src/jackdaw/streams/protocols.clj 100.00% <ø> (ø)
src/jackdaw/streams.clj 82.53% <50.00%> (-0.67%) :arrow_down:
src/jackdaw/streams/interop.clj 82.71% <100.00%> (+2.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update daa8387...97cfef7. Read the comment docs.