Port to kafka v3.2.0 and update deps

FundingCircle / jackdaw

A Clojure library for the Apache Kafka distributed streaming platform.

https://fundingcircle.github.io/jackdaw/

BSD 3-Clause "New" or "Revised" License

368 stars 80 forks source link

Port to kafka v3.2.0 and update deps #321

Closed ghaskins closed 1 year ago

ghaskins commented 2 years ago

Signed-off-by: Greg Haskins greg@manetu.com

gphilipp commented 2 years ago

Hi @ghaskins, thanks for the PR this is very much appreciated. We've discussed this internally and would prefer to see it split into 3 PRs:

one that allows to stick with 2.x but removes all calls to deprecated stuff and upgrades libs
one that upgrades to 3.2.0
last one to upgrade to clojure 1.11.1

I'll cherry pick changes from your branch if you don't mind (and give credit where it's due of course).

ghaskins commented 2 years ago

@gphilipp the plan makes sense, and of course I don't mind. Ty!

BTW: I actually tried a variation of your proposal (doing the 2.x with updates as a different patch) and it was inexplicably failing UTs. I didn't investigate too deeply, though, since I had just finished getting the 3.2 port to work. I did not try to split clojure out, though.

mt3593 commented 1 year ago

Hi all, any update on this? Happy to help out if I can.

kidpollo commented 1 year ago

@marcoccchan @99-not-out this is also important. Specially for ppl with M1 macs. There is even newer kafka libs now. I also don't see a point of splitting this into multiple prs

minimal commented 1 year ago

Thanks this was included in #353 and released in https://github.com/FundingCircle/jackdaw/releases/tag/0.9.10