search

Fungus-Community-Edition / Fungus

An attempt at a community revival of the Fungus extention for Unity
MIT License
8 stars 1 forks source link

Move all extension unitypackages to 2nd repo. #7

Closed esklarski closed 1 year ago

esklarski commented 1 year ago

We need to ensure all external package references are handled according to guidelines. The obvious culprit here is LeanTween, but there may be more.

My read of the policy is that these are the key areas we need address:

Assets with dependencies from Package Manager only include the necessary packages for the asset to work.

You are solely responsible for ensuring that you have all necessary rights to distribute your content on the Asset Store and for end users rightfully to use that content and distribute it as part of a Licensed Product. This means that you are either the owner of all such necessary rights or you have a valid license from the rightsholder.

Your submission includes a Third-Party Notices text file listing fonts, audio, and other third-party components with dependent licenses. You are responsible for ensuring that dependent licenses are compatible with the Asset Store EULA and include a license file detailing the component that it is covering. The product description on the Asset Store also contains a notice stating the third-party software licensing included in the package. For example: "Asset uses [name of component] under [name of license]; see Third-Party Notices.txt file in package for details."

I don't see why we need to remove LeanTween, it seems it should be possible to include it. According to (2.2.a and 2.2.b) the problem is that the LeanTween files being in a compressed file (.unitypackage)

The problem IS that we have Playmaker and Spine integration packages that by being in a .unitypackage:

... obscure most of, or the entirety of the content.

Since LeanTween has an open license, we just need to include it in a different way. Which would seem to be as package dependancy to the LeanTween git, or if we just bring the scripts under the Fungus namespace and properly handle the attributions.

Since LT hasn't seen update since 2018, I think we might as well go with the second option so Fungus is complete without a network connection.

Therefore we need to setup a second repository that can host things like this, and remove them from the Fungus project.

esklarski commented 1 year ago

See: #19

esklarski commented 1 year ago

Closed by #19