FunkFrog / ShareSuite

Risk of Rain 2 Item, Money, & Equipment sharing mod build upon BepInEx
https://thunderstore.io/package/FunkFrog-and-Sipondo/ShareSuite/
GNU General Public License v3.0
40 stars 26 forks source link

PrinterCauldronFix only appears to prevent duplication of items that are set to shared #104

Closed Butternubs closed 4 years ago

Butternubs commented 4 years ago

Myself and a few other friends have integrated this mod into our runs to make it a bit fairer. We only share white items, and green/red/boss etc. are all personal, to ensure we can all have varied builds.

We ran into an issue multiple times where cauldrons and 3d printers of colours we did not share would give an item directly to the user, and also drop the item out like normal, thus duplicating the item. I noticed a couple of issues raised prior regarding scrapped items, but this is probably a separate issue.

I couldn't replicate this on a server by myself, but it would happen every single time without fail when playing with other people.

Config is set up as follows:

## Settings file was created by plugin ShareSuite v2.1.0
## Plugin GUID: com.funkfrog_sipondo.sharesuite

[Balance]

## Changes the way shared equipment handles blacklisted equipment. If true, blacklisted equipment will be dropped on the ground once a new equipment is shared. If false, blacklisted equipment is left untouched when new equipment is shared.
# Setting type: Boolean
# Default value: false
DropBlacklistedEquipmentOnShare = false

## When enabled each player (except the player who picked up the item) will get a randomized item of the same rarity.
# Setting type: Boolean
# Default value: false
RandomizeSharedPickups = false

## Toggles randomizing Lunar items in RandomizeSharedPickups mode.
# Setting type: Boolean
# Default value: true
LunarItemsRandomized = true

## Toggles randomizing Boss items in RandomizeSharedPickups mode.
# Setting type: Boolean
# Default value: false
BossItemsRandomized = false

## Toggles 3D printer and Cauldron item dupe fix by giving the item directly instead of dropping it on the ground.
# Setting type: Boolean
# Default value: true
PrinterCauldronFix = true

## Toggles whether or not dead players should get copies of picked up items.
# Setting type: Boolean
# Default value: false
DeadPlayersGetItems = false

## Toggles override of the scalar of interactables (chests, shrines, etc) that spawn in the world to your configured credit.
# Setting type: Boolean
# Default value: true
OverridePlayerScaling = false

## If player scaling via this mod is enabled, the amount of players the game should think are playing in terms of chest spawns.
# Setting type: Double
# Default value: 1
InteractablesCredit = 1

## Toggles override of the scalar of boss loot drops to your configured balance.
# Setting type: Boolean
# Default value: true
OverrideBossLootScaling = false

## Specifies the amount of boss items dropped when the boss drop override is true.
# Setting type: Int32
# Default value: 1
BossLootCredit = 1

## Toggles override of the scalar of Void Field loot drops to your configured balance.
# Setting type: Boolean
# Default value: true
OverrideVoidLootScaling = false

## Specifies the amount of Void Fields items dropped when the Void Field scaling override is true.
# Setting type: Int32
# Default value: 1
VoidFieldLootCredit = 1

## Toggles the reduction in sacrifice loot drops to be balanced with shared items enabled.
# Setting type: Boolean
# Default value: true
SacrificeFixEnabled = true

[Settings]

## Toggles whether or not the mod is enabled. If turned off while in-game, it will unhook everything and reset the game to it's default behaviors.
# Setting type: Boolean
# Default value: true
ModEnabled = true

## Toggles money sharing between teammates. Every player gains money together and spends it from one central pool of money.
# Setting type: Boolean
# Default value: true
MoneyShared = false

## Toggles item sharing for common (white color) items.
# Setting type: Boolean
# Default value: true
WhiteItemsShared = true

## Toggles item sharing for rare (green color) items.
# Setting type: Boolean
# Default value: true
GreenItemsShared = false

## Toggles item sharing for legendary (red color) items.
# Setting type: Boolean
# Default value: true
RedItemsShared = false

## Toggles item sharing for equipment.
# Setting type: Boolean
# Default value: false
EquipmentShared = false

## Toggles item sharing for Lunar (blue color) items.
# Setting type: Boolean
# Default value: false
LunarItemsShared = false

## Toggles item sharing for boss (yellow color) items.
# Setting type: Boolean
# Default value: true
BossItemsShared = false

## Toggles detailed item pickup messages with information on who picked the item up and who all received the item.
# Setting type: Boolean
# Default value: true
RichMessagesEnabled = true

## Toggles the money scalar, set MoneyScalar to an amount to fine-tune the amount of gold you recieve.
# Setting type: Boolean
# Default value: false
MoneyScalarEnabled = false

## Modifies player count used in calculations of gold earned when money sharing is on.
# Setting type: Double
# Default value: 1
MoneyScalar = 1

## Items (by index) that you do not want to share, comma separated. Please find the item indices at: https://github.com/risk-of-thunder/R2Wiki/wiki/Item-&-Equipment-IDs-and-Names
# Setting type: String
# Default value: 53,60,82,86
ItemBlacklist = 53,60,82,86

## Equipment (by index) that you do not want to share, comma separated. Please find the indices at: https://github.com/risk-of-thunder/R2Wiki/wiki/Item-&-Equipment-IDs-and-Names
# Setting type: String
# Default value: 
EquipmentBlacklist = 
Sipondo commented 4 years ago

Resolved by yourself in commit (8f0b3a6).

Sipondo commented 4 years ago

On another note, @Butternubs please open a new issue regarding the problems you found with the scrapper!

Butternubs commented 4 years ago

I believe the scrapper bug had already been resolved prior to me raising this issue, as I haven’t encountered it during my play through. I was only referencing #102 in the original ticket :) If I do encounter another scrapper issue, I’ll be sure to raise it.

Cheers!