FunkFrog / ShareSuite

Risk of Rain 2 Item, Money, & Equipment sharing mod build upon BepInEx
https://thunderstore.io/package/FunkFrog-and-Sipondo/ShareSuite/
GNU General Public License v3.0
39 stars 27 forks source link

No popup or chat message on item pickup after Anniversary Update #125

Closed ZeroKnight closed 3 years ago

ZeroKnight commented 3 years ago

Installed Mods

Describe the bug

The item description popup does not appear when picking up an item, nor is the pickup reported to chat. The following error is logged:

RoR2.Chat.SendBroadcastChat(RoR2.Chat/PlayerChatMessage)
Stack trace:
ShareSuite.ItemSharingHooks.OnGrantItem (On.RoR2.GenericPickupController+orig_GrantItem orig, RoR2.GenericPickupController self, RoR2.CharacterBody body, RoR2.Inventory inventory) (at <d216f435dd2c43988ddd605bdb328768>:0)
DMD<>?711099136.Hook<RoR2.GenericPickupController::GrantItem>?2030556928 (RoR2.GenericPickupController , RoR2.CharacterBody , RoR2.Inventory ) (at <5f47fab83267448e92ada7b0f14c91ff>:0)
RoR2.GenericPickupController.AttemptGrant (RoR2.CharacterBody body) (at <c36b0eadbe0a4afc83f7e70a917dc2c1>:0)
RoR2.GenericPickupController.OnTriggerStay (UnityEngine.Collider other) (at <c36b0eadbe0a4afc83f7e70a917dc2c1>:0)

N.B. This happened in Singleplayer; I have not tested multiplayer.

To Reproduce Steps to reproduce the behavior:

  1. Start Singleplayer run
  2. Pick up any item from a chest, shop, etc.

Screenshots

It's obscured slightly, but you can see the white rectangle that highlights an item that was just picked up, however, no chat message was printed and the bottom popup was never displayed. image

Additional context As you may know, the 2-Year Anniversary update was released today, which introduced significant changes.

For what it's worth, as R2API has not been updated at the time of writing, this warning is logged as well:

[Warning: R2API] This version of R2API was built for build id "5440050", you are running "6427269".
[Warning: R2API] Should any problems arise, please check for a new version before reporting issues.
LuniaDev commented 3 years ago

Happens in MP too.

FunkFrog commented 3 years ago

Please try the test version of the mod in the ShareSuite Discord’s announcements channel and let me know if this issue is resolved.

ZeroKnight commented 3 years ago

Hi @FunkFrog, the test version you mention does indeed fix this issue! At least for singleplayer; I can't test MP at the moment to confirm that it works as well.

FunkFrog commented 3 years ago

Just tested with the new MMHOOK, seems to work fine. Thanks for the report :)