Scavenger Bags only dropping 2 items of any rarity instead of 10.

[Yangjo]

Installed Mods ItemStats 2.2.1 R2API (included with SharedSuite) ShrineOfDio 1.5.1 ShareSuite-R2 2.5.1 DropinMultiplayer 1.0.14 CommandArtifactItemDrops 0.3.1 TooManyFriends 1.1.1

Describe the bug: This bug is a resurfaced bug that was fixed in a previous version: 2.0.1 Fixed an issue regarding Scavengers dropping less items than intended. Whenever a scavenger dies, looting their bag only drops 2 items.

To Reproduce Steps to reproduce the behavior:

1. Spawn a Scavenger
2. Kill the Scavenger
3. Open the Scavenger Bag
4. See only a couple items drop
5. Additionally, the Scavenger Boss in A Moment, Whole, only drops 2 lunar coins instead of the intended number.

Expected behavior Scavenger bags are definitely supposed to drop 10 items of any rarity. Similarly, the Scavenger Boss for in A Moment, Whole only drops 2 Lunar Coins.

[FunkFrog]

This is intentional. See #75, #92, and https://github.com/FunkFrog/RoR2SharedItems/commit/7eb36262c8782e9b7fdf125dcaceb3334e7956cd.

[FunkFrog]

Oh wait no I’m stupid sorry yeah I’ll look into this lol

[Yangjo]

I just tested this again with just 2 players in a session and only 2 mods: Installed Mods DebugToolkit 3.4.2 ShareSuite-R2 2.5.1

This time I only got 5 items that dropped from the Scavenger bag. I also tried in solo, but solo seems to drop the appropriate number, even within a multiplayer session with just me in it. Perhaps there's some weird inverted scaling going on? So maybe it is an intended feature?

I also feel like there's an issue with interactables spawns being far less than even the single player amount with larger players numbers in a session, is this all intentional?

[FunkFrog]

Yes, scav drops scale inversely to the amount of players in the lobby. Also, interactables spawns should just be the normal for one player no matter the amount of players in a lobby.

[FunkFrog]

The drop count should be amount of singleplayer drops / player count drops, or 2 drops, whichever is higher.

[Yangjo]

I believe there were 6 or 7 players at the time then, when the scavenger bag only dropped 2 items, or 2 lunar coins. So perhaps it was intentional then.

If this is an intentional feature, and in turn, causes the A Moment, Whole boss to drop only 2 lunar coins (or more depending on player count), I'd like to feature request two things then: Config options for shared lunar coins on pickup Scavenger bag Drop Scaling

I know there are other mods for shared lunar coins on pickup, but I think it would make a lot of sense for this mod to provide that, or at least options for such.

[FunkFrog]

We’ve said multiple times before, and I’d like to continue this stance, we don’t want to step on the toes of other mods, so we’ve refrained from adding lunar coin sharing.

What would scav bag scaling look like? What parameter would it control? I could probably implement it for the next release.

[Yangjo]

I'd say options to turn off the scaling completely and/or configurable inverse scaling instead of relying on player count. So it could be two separate commands True/False and a custom inverse scaling number Or maybe all in one command by indicating 0 for default inverse sharesuite scaling 1-10 for custom inverse scaling, 1 being no change from vanilla ror2.

If you have a better idea of configurable options, you don't have to mind me. I think my proposal might be too confusing.

[FunkFrog]

So turning off the scaling would result in 8-10 items per player which would be WILDLY broken and is why we implemented the fix in the first place.

Also, as far as the inverse scaling goes, what would each of these numbers represent? The player count? The idea of the scalar was to remove the need to do configuration.

How about a toggle between manual and automatic, with a config option for the lowest amount to drop, and a config option for the player count for manual configuration?

[Yangjo]

That seems good. I recall in previous versions of ror2, each scavenger would drop their bag. Now it's limited to one bag per level. I understand it may be broken, but I don't really know why in vanilla ror2, mp and sp drop the same exact amount of items. So it's like the devs didn't balance for mp in the first place?

[MellowEdge]

I just wanted to add that is you're only using this mod for money sharing, then the scavenger drops shouldn't scale. I'm using this mod for shared money pool only, so the item drops work as vanilla for me, but the scavengers drop 10/number of players.