search

FunkFrog / ShareSuite

Risk of Rain 2 Item, Money, & Equipment sharing mod build upon BepInEx
https://thunderstore.io/package/FunkFrog-and-Sipondo/ShareSuite/
GNU General Public License v3.0
39 stars 27 forks source link

Item duplication glitch #132

Closed alois-gaucher closed 3 years ago

alois-gaucher commented 3 years ago

Installed Mods "bbepis-BepInExPack-5.4.9", "RiskofThunder-HookGenPatcher-1.2.0", "tristanmcpherson-R2API-3.0.11", "XoXFaby-MMHOOK_Standalone-1.0.1", "XoXFaby-BetterUI-2.0.2", "XoXFaby-BetterGameplay-1.1.0", "TheRealElysium-EmptyChestsBeGone-1.1.1", "mistername-NoBossNoWait-1.1.3", "wildbook-TooManyFriends-1.1.1", "niwith-DropinMultiplayer-1.0.16", "MagnusMagnuson-ScannerPlusOne-2.6.1", "Pickleses-TeleporterShow-2.3.2", "NotTsunami-ShowDeathCause-1.0.4", "TheRealElysium-WaxQuailMultiJump-1.0.1", "tristanmcpherson-KookehsDropItem_BepInEx-2.2.1", "Constant-ine-PauseInMultiplayer-1.0.8", "xiaoxiao921-RideMe-1.0.6", "Timmeh42-2-StealthySpawn-1.0.0", "mries92-SafeMenus-1.0.1", "neutrino-steak-RespawnAfterBoss-0.1.0", "FunkFrog-and-Sipondo-ShareSuite-2.5.1", "wildbook-MiniRpcLib-0.0.2", "Jarlyk-Raincoat-1.1.0"

Describe the bug When using ShareSuite with KookehsDropItem, if you drop an item to a friend, this friend can take it and then the item is duplicated, because you both get the item.

To Reproduce Steps to reproduce the behavior:

  1. Use ShareSuite + KookehsDropItem
  2. Drop an item to player 2
  3. Player 2 takes the item
  4. Your item is duplicated

Expected behavior When you take an item on the ground, if this item was dropped by a player, it shouldn't give this item to both of you.

Screenshots https://imgur.com/a/KVle7GD

Additional context Add any other context about the problem here.

FunkFrog commented 3 years ago

Our mod isn’t compatible with dropitem and I currently have no intention to make it function with it as the level of work required far outweighs the benefit.

This was an issue waaaaay back when dropitem first came out and I think we discussed it? Let me try to find the issue

FunkFrog commented 3 years ago

I can’t find it but our solution involved either adding a new private field to item drops that specifies whether or not the item was dropped by a player, possibly destroying any semblance of compatibility with, like, everything