search

FunkFrog / ShareSuite

Risk of Rain 2 Item, Money, & Equipment sharing mod build upon BepInEx
https://thunderstore.io/package/FunkFrog-and-Sipondo/ShareSuite/
GNU General Public License v3.0
39 stars 27 forks source link

Gold Modifying Items and Characters Cease Gold Modifying Functions #133

Closed imakunee closed 3 years ago

imakunee commented 3 years ago

Installed Mods BepInExPack by bbepis 5.4.9 R2API by tristanmcpherson 3.0.11 MMHOOK_Standalone by XoXFaby 1.0.1 ShareSuite by FunkFrog-and-Sipondo 2.5.1 HookGenPatcher by RiskofThunder 1.2.0 TILER2 by ThinkInvis 4.0.2 ClassicItems by ThinkInvis 5.0.1

Alternatively:

BepInExPack by bbepis 5.4.9 R2API by tristanmcpherson 3.0.11 MMHOOK_Standalone by XoXFaby 1.0.1 ShareSuite by FunkFrog-and-Sipondo 2.5.1 TheHouse by JavAngle 1.4.0 HookGenPatcher by RiskofThunder 1.2.0

Describe the bug When using gold modifying items added by Classic Items with Share Suite enabled (such as Piggy Bank, which gives gold over time) no gold is added. This appears to be true for other gold modifying items in that mod as well.

When using gold modifying abilities from The House (such as the Diamond card or Wheel of Fortune) no gold is added or removed. All other features of the ability seem to work appropriately.

These items and abilities function correctly when Share Suite is disabled.

To Reproduce Steps to reproduce the behavior:

  1. Install ShareSuite and either TheHouse or ClassicItems
  2. Use a gold modifying card from TheHouse or obtain a gold modifying item from ClassicItems (command artifact was used in testing)
  3. No gold is added or subtracted

Expected behavior The items and abilities should add or subtract income as they normally are stated to function.

FunkFrog commented 3 years ago

These mods would need to access ShareSuite’s method to check whether or not gold is shared, and if so, access the add money method to add money to the characters.

This could be temporarily remedied by turning shared money off in your ShareSuite configuration

Thanks for the report, feel free to link this comment if you make an issue for the other mods you’re referring to :)

FunkFrog commented 3 years ago

For more information, see #67

FunkFrog commented 3 years ago

https://github.com/FunkFrog/RoR2SharedItems/blob/a2d03796db3fc20add445aa80b5265090031ce77/ShareSuite/MoneySharingHooks.cs#L100 — check whether or not shared money is enabled

https://github.com/FunkFrog/RoR2SharedItems/blob/a2d03796db3fc20add445aa80b5265090031ce77/ShareSuite/MoneySharingHooks.cs#L85 — add money via the shared money system