FunkFrog / ShareSuite

Risk of Rain 2 Item, Money, & Equipment sharing mod build upon BepInEx
https://thunderstore.io/package/FunkFrog-and-Sipondo/ShareSuite/
GNU General Public License v3.0
39 stars 27 forks source link

Fix for single player games not starting with 15 starter money #137

Closed ryansonshine closed 3 years ago

ryansonshine commented 3 years ago

This change fixes an issue where single player games would not start with the $15 expected in single player runs on the first stage.

Closes issue #135

ryansonshine commented 3 years ago

@FunkFrog can you review when you get a chance?

Thanks

Sipondo commented 3 years ago

Good idea. The money sharing code shouldn't be running if ShareSuite isn't enabled. However, I don't think the check should solely be applied on the reset call (either it shouldn't, or it should be on all calls). In any case, the Update() call seems to be the main perpetrator, and one could argue to fence off all MoneySharingHooks calls as well in good practice.

ryansonshine commented 3 years ago

@Sipondo , any update on this? I've been toggling the plugin on/off when I switch from multiplayer to single player.