search

FunkFrog / ShareSuite

Risk of Rain 2 Item, Money, & Equipment sharing mod build upon BepInEx
https://thunderstore.io/package/FunkFrog-and-Sipondo/ShareSuite/
GNU General Public License v3.0
39 stars 26 forks source link

Setting Interractable credits to a decimal number prevents interractable spawns #38

Closed Compegen closed 5 years ago

Compegen commented 5 years ago

Installed Mods ShareSuite

Describe the bug Setting interractable credits to a number other than a whole number prevents anything from spawning

To Reproduce Set interractblesCredit to 1.5, play game, items won't spawn.

Expected behavior To be able to use partial multipliers and receive 1.5x the items

FunkFrog commented 5 years ago

The interactablesCredit scalar is based on an amount of players, and only accepts whole (integer) numbers. This is working as intended.

Compegen commented 5 years ago

Would it be possible to add this as a partial multiplier? Flood Warning multiplies interactable credits by 1.25x

FunkFrog commented 5 years ago

Yes, it's possible, but I would have to make a decent amount of modifications to how the system works, as well as rewrite part of the SharedModLibrary hook, to allow for this minor change. I just don't see it as a worthwhile time investment, though if you would like to fork and make the changes yourself, and make a PR, I would not mind merging that change.

FunkFrog commented 5 years ago

(I would normally be fine making this change but I'm both in the process of starting school again and working on other projects, namely the Thunderstore, that require my more direct attention)