search

FunkFrog / ShareSuite

Risk of Rain 2 Item, Money, & Equipment sharing mod build upon BepInEx
https://thunderstore.io/package/FunkFrog-and-Sipondo/ShareSuite/
GNU General Public License v3.0
40 stars 26 forks source link

Crowdfunder doesn't subtract money when MoneyShared=true #68

Closed blazingdrummer closed 4 years ago

blazingdrummer commented 4 years ago

Installed Mods BepinExPack v3.0.0 R2API v2.3.7 DebugToolkit v3.1.2 MiniRpcLib v0.0.1 KeyBindForConsole v2.0.1 MacroCommands v2.0.0 BepinexConfigurationManager v2.0.0 FluffyLabsConfigManagerTools v1.0.1 FixedSplitscreen v0.0.3 ShareSuite v1.14.0

Describe the bug Equipping the Crowdfunder and activating it does not consume any money while it's running, resulting in the ability to infinitely use it. This was first reported by one of my players running a larger list of mods (see attached picture, was using ShareSuite 4fe9b9a681108e2227b35f1c95827fc13b9ab902* at the time) in a multiplayer game and reproduced by me using the mods listed above.

*refers to the version posted in #contributor-chat by Harb on the ShareSuite discord https://discordapp.com/channels/614480101647843330/632394254014218268/662086046946689035

FullModList

To Reproduce Steps to reproduce the behavior:

  1. Install the above mods and set "MoneyShared=true".
  2. Start a single/multiplayer game.
  3. Open the console and type "give_equip TheCrowdfunder".
  4. Activate the equipment.

Expected behavior When the Crowdfunder is activated, it should drain money from both players' shared money pool at the normal rate.

Screenshots N/A

Additional context Note that I am using R2ModMan to install and disable mods and FixedSplitscreen to simulate a multiplayer game with multiple players for my own ease of use. The side effects of these methods are unknown but a few previously tested bugs have been replicated in a true multiplayer game after being discovered using these methods, so I have no reason to doubt their reliability so far.

I also have been using DebugToolkit and a few other admin mods as seen above to speed up testing, but would be happy to attempt to reproduce the bug with a clean install of Bepin/R2API and in a true single/multiplayer game if necessary. Just get in contact with me on Discord @blazingdrummer#1929.

eebssk1 commented 4 years ago

Well I don't think this can be fixed easily since server only handle the Bullets,not the Fire action(handled on clients).

FunkFrog commented 4 years ago

@eebssk1 Kinda. It’ll be fixed sometime in the future, I’ve been tied up with college stuff and moving.

FunkFrog commented 4 years ago

Fixed in next version