search

FunkFrog / ShareSuite

Risk of Rain 2 Item, Money, & Equipment sharing mod build upon BepInEx
https://thunderstore.io/package/FunkFrog-and-Sipondo/ShareSuite/
GNU General Public License v3.0
39 stars 26 forks source link

Red item cauldron in the Bazaar creates duplicates with PrinterCauldronFix=true #69

Closed blazingdrummer closed 4 years ago

blazingdrummer commented 4 years ago

Installed Mods BepinExPack v3.0.0 R2API v2.3.7 DebugToolkit v3.1.2 MiniRpcLib v0.0.1 KeyBindForConsole v2.0.1 MacroCommands v2.0.0 BepinexConfigurationManager v2.0.0 FluffyLabsConfigManagerTools v1.0.1 FixedSplitscreen v0.0.3 ShareSuite v1.14.0

Describe the bug With PrinterCauldronFix set equal to "true", the cauldron in the Bazaar that converts 5 green items to 1 red item places the red item directly into the user's inventory as intended, but also drops another copy of the red item onto the ground, like you would see in vanilla behavior, resulting in item duplication.

This was first reported by one of my players running a larger list of mods (see attached picture, was using ShareSuite 4fe9b9a681108e2227b35f1c95827fc13b9ab902* at the time) in a multiplayer game and reproduced by me using the mods listed above.

*refers to the version posted in #contributor-chat by Harb on the ShareSuite discord https://discordapp.com/channels/614480101647843330/632394254014218268/662086046946689035

FullModList

This issue was also reported by other users on the Discord channel. https://discordapp.com/channels/614480101647843330/614866493468966913/660050115351937034 https://discordapp.com/channels/614480101647843330/614866493468966913/663408652169773066

To Reproduce Steps to reproduce the behavior:

  1. Install the above mods and set "PrinterCauldronFix=true".
  2. Start a multiplayer game.
  3. Open the console and type "next_stage Bazaar".
  4. Type "give_item 5".
  5. Use the red item cauldron in the Bazaar.

Expected behavior The cauldron should place the item directly into the player's inventory and NOT drop a red item on the ground.

Screenshots N/A

Additional context Note that I am using R2ModMan to install and disable mods and FixedSplitscreen to simulate a multiplayer game with multiple players for my own ease of use. The side effects of these methods are unknown but a few previously tested bugs have been replicated in a true multiplayer game after being discovered using these methods, so I have no reason to doubt their reliability so far.

I also have been using DebugToolkit and a few other admin mods as seen above to speed up testing, but would be happy to attempt to reproduce the bug with a clean install of Bepin/R2API and in a true single/multiplayer game if necessary. Just get in contact with me on Discord @blazingdrummer#1929.

FunkFrog commented 4 years ago

Could not reproduce with only ShareSuite + DebugToolkit (and it's dependency)