search

FunkFrog / ShareSuite

Risk of Rain 2 Item, Money, & Equipment sharing mod build upon BepInEx
https://thunderstore.io/package/FunkFrog-and-Sipondo/ShareSuite/
GNU General Public License v3.0
39 stars 26 forks source link

Able to duplicate items in multiplayer #79

Closed nathangeranis closed 4 years ago

nathangeranis commented 4 years ago

Installed Mods A list of all currently installed mods and their version numbers.

BepInEx Pack 3.0 R2API 2.3.22 Too Many Friends 1.0 DifficultyModifier 1.1 Stats Display 2.3.0 Mini RPC Lib 0.0.1 Increase Huntress Range 1.0.0 Wax Quail Multi Jump 1.0.1 Lunar Coin Share on Pickup 3.5.0 Pingprovements 1.4.1 Shrine of Dio 1.2.0 Unmodded Clients 1.1.4 Kookehs Drop Item Bep In Ex 2.0.2 (I believe this combined with ShareSuite is the culprit) Dropin Multiplayer 1.1.2 RPG Mod 2.0.1 DPS Meter 0.0.6 Item Stats Mod 1.4.0 Steam Build ID 1.2.0 Compass 0.0.3 No Boss No Wait 1.1.1 Share Suite 1.14.0 Bigger Bazaar 1.7.3 Boss Item Drop 1.0.0 Bad Ass Engi 1.0.1

Describe the bug A clear and concise description of what the bug is.

Join a multiplayer game with these mods or potentially just Share Suite and Drop Items. Get an item, make sure it's shared with the share suite. Have one player drop that item, and pick it back up. That player will still have just one item, but the second will have two of the same item. Infinitely duplicable.

To Reproduce Steps to reproduce the behavior:

  1. Download & install mentioned mods.
  2. Have friends.
  3. Join multiplayer game with said friends.
  4. Have someone pick up an item.
  5. Have person drop that item.
  6. Have that same person pick that item back up.
  7. Everyone else now has +1 more of that item.
  8. Repeat ad nauseum until you have 226 Aegis and can never die.

Expected behavior A clear and concise description of what you expected to happen.

When an item that is shared is dropped, it should be dropped from everyone, not just the player dropping it.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

This also works if you have 3+ players, player A drops the item and player B picks it up, now player A will have 1, and both player B and C-Z will have two.

FunkFrog commented 4 years ago

@nathangeranis We previously had this mod in our list of incompatibilities and need to re-add it. We do not intend to add support for this feature at the current time.