FunkFrog / ShareSuite

Risk of Rain 2 Item, Money, & Equipment sharing mod build upon BepInEx
https://thunderstore.io/package/FunkFrog-and-Sipondo/ShareSuite/
GNU General Public License v3.0
39 stars 26 forks source link

Automatically detect Multitudes #88

Closed xiaoxiao921 closed 2 years ago

xiaoxiao921 commented 4 years ago

Makes it so that users doesnt have to change their config everytime to make Multitudes work

Sipondo commented 4 years ago

Thanks for the pr! I think two changes would make this viable:

  1. Check for multitudes where it matters, e.g. on World generation. It is very costly to do this in update.
  2. If possible, check if multitudes actually changed the number. If multitudes equals the amount of players, normal execution of ss should follow.
xiaoxiao921 commented 4 years ago

It only fire in ctor, i have to say having the Update() at the top threw me off myself, I just initialy threw the bool field at the top of the class, but yeah it only fire in the ctor, since its a soft dep multitudes if present will always be fired before, i now check if the config value is actually different by caching a ref to the config entry and return true depending on that

FunkFrog commented 3 years ago

Okay, this has been open for a while and I kinda forgot it was here. I'll be taking a look at it later tonight