search

FunkFrog / ShareSuite

Risk of Rain 2 Item, Money, & Equipment sharing mod build upon BepInEx
https://thunderstore.io/package/FunkFrog-and-Sipondo/ShareSuite/
GNU General Public License v3.0
39 stars 26 forks source link

Item pickup messages are printed twice when RichMessagesEnabled = false #96

Closed blazingdrummer closed 3 years ago

blazingdrummer commented 4 years ago

Installed Mods bbepis-BepInExPack-3.2.0 tristanmcpherson-R2API-2.4.21 Harb-DebugToolkit-3.3.1 JackPendarvesRead-FluffyLabsConfigManagerTools-1.0.1 JackPendarvesRead-BepinexConfigurationManager-2.0.0 kristiansja-KeyBindForConsole-2.0.1 JackPendarvesRead-MacroCommands-2.0.0 mistername-IlLine-1.0.0 FunkFrog-and-Sipondo-ShareSuite-2.0.0

Describe the bug When experimenting with potential temporary solutions to https://github.com/FunkFrog/RoR2SharedItems/issues/94, I realized that picking up an item while RichMessagesEnabled = false resulted in a duplicate pickup message printed to chat in singleplayer. Untested in multiplayer. Untested with the default config; use attached config instead.

To Reproduce

  1. Install ShareSuite and dependencies.
  2. Download and place the attached config in BepInEx/config. Change extension from .txt to .cfg.
  3. Start a singleplayer game and pick up any item. Two pickup messages should appear in chat.

Expected behavior Only one message should be printed. I haven't checked if stack count shows up properly or not (see https://github.com/FunkFrog/RoR2SharedItems/issues/94).

Sipondo commented 3 years ago

Resolved as of (20b02bb).