FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.96k stars 2.29k forks source link

Enhancement: Fix DiscordRpc compile issue #1830

Closed AndrewIdot closed 6 months ago

AndrewIdot commented 3 years ago

What is your suggestion, and why should it be implemented?

My suggestion is adding this line next to the DiscordRpc line in Project.xml: <haxelib name="discord_rpc.DiscordRpc" if="desktop"/>

As well as adding this command in the compile tutorial: haxelib git discord_rpc.DiscordRpc https://github.com/Aidan63/linc_discord-rpc

Some people had this bug (including me) and I found a good solution. Basically, it fixes the below issue some people had with compilation: source/Discord.hx:4: characters 8-30 : Type not found : discord_rpc.DiscordRpc source/Discord.hx:13: characters 3-13 : Type not found : DiscordRpc source/Discord.hx:23: characters 4-14 : Type not found : DiscordRpc source/Discord.hx:28: characters 3-13 : Type not found : DiscordRpc source/Discord.hx:33: characters 3-13 : Type not found : DiscordRpc source/Discord.hx:38: characters 3-13 : Type not found : DiscordRpc source/Discord.hx:74: characters 3-13 : Type not found : DiscordRpc

DotWith commented 3 years ago

You should maybe make this a pull request, and try to get discord rpc working on linux, hashlink, etc.

Make sure to make all the #if desktop to #if discord_rpc because you specified it in the project.xml.

ghost commented 2 years ago

ok. where you have the problem on there right do #if desktop on there and at the bottom put #end