Ghost Tapping in Botplay results in missing and can cause the player to die - Githubissues

FunkinCrew / Funkin

A rhythm game made with HaxeFlixel

https://www.newgrounds.com/portal/view/770371

Other

2.92k stars 2.27k forks source link

Ghost Tapping in Botplay results in missing and can cause the player to die #2358

Open ZeitHeld opened 4 months ago

ZeitHeld commented 4 months ago

If you are playing the game in a browser, what site are you playing it from?

[ ] Newgrounds
[X] Itch.io? Specify below
- [X] Windows
- [ ] Mac
- [ ] Linux

If you are playing the game in a browser, what browser are you using?

[ ] Google Chrome (or chomium based like Brave, vivaldi, MS Edge)
[ ] Firefox
[ ] Safari

What version of the game are you using? Look in the bottom left corner of the main menu. (ex: 0.2.7, 0.2.1, shit like that)

0.3.2

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.

Please describe your issue. Provide extensive detail and images if possible.

Open Chart Editor
Go to any song
Enable "Bot Play mode" in "Window > Playtest Properties"
Smash the Arrow Keys
Die to Ghost Tapping (with seemingly full health)

If your game is FROZEN and you're playing a web version, press F12 to open up browser dev window, and go to console, and copy-paste whatever red error you're getting

EliteMasterEric commented 3 months ago

Reproduced.

TehEpikNoobKing commented 1 month ago

I actually fixed this bug pretty easily in the source.

PlayState.hx - function processInputQueue() (first line is 2569) image_2024-08-02_224921341

(The highlighted green is the added lines) (Tested myself)

Hundrec commented 1 month ago

Cool! How are inputs handled with this change? Do they do nothing at all?

Hundrec commented 8 hours ago

Bot play mode now skips handling misses in 0.5.0, so this is fixed!