FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.98k stars 2.29k forks source link

[BUG] (Charting State) Loading a song without difficulty/variation behaves unexpecfully or crashes #2468

Open gamerbross opened 6 months ago

gamerbross commented 6 months ago

If you had loaded previously a song with another variation (like Erect) or difficulty and then try to load a dfifferent song unexpectedly changes song data or crashes. (I think only crashes with song templates)

This could be easily fixed by resetting the variation and difficulty when loading a different song.

Video example: (using song template)

https://github.com/FunkinCrew/Funkin/assets/55158797/af376573-099d-4044-b609-f9dc24ac16d0

Video example: (loading existing chart)

https://github.com/FunkinCrew/Funkin/assets/55158797/a24ae89c-152f-4f76-bd9b-8a57d6d7d074

amyspark-ng commented 6 months ago

nice catch!

NotHyper-474 commented 5 months ago

0.4.0 and still has not been fixed

AbnormalPoof commented 1 month ago

Does this still happen in v0.5.1?

NotHyper-474 commented 1 month ago

Does this still happen in v0.5.1?

Yes, and can be replicated if you open a song without a Pico variation as well.

[lime.utils.Assets] ERROR: There is no BINARY asset with an ID of "songs:assets/songs/tutorial/Inst-pico.ogg"
  in lime/utils/Log.hx#37
  in lime/utils/Assets.hx#138
  in lime/utils/Assets.hx#169
  in openfl/utils/Assets.hx#135
  in funkin/Assets.hx#29
  in funkin/ui/debug/charting/handlers/ChartEditorAudioHandler.hx#105
  in funkin/ui/debug/charting/handlers/ChartEditorImportExportHandler.hx#73
  in funkin/ui/debug/charting/dialogs/ChartEditorWelcomeDialog.hx#162
  in haxe/ui/util/EventMap.hx#90
  in haxe/ui/backend/ComponentBase.hx#441
  in haxe/ui/backend/flixel/MouseHelper.hx#201
  in haxe/ui/backend/flixel/MouseHelper.hx#191
  in haxe/ui/backend/flixel/MouseHelper.hx#173
  in haxe/ui/backend/flixel/MouseHelper.hx#103
NotHyper-474 commented 3 weeks ago

Partial duplicate of #2411